Skip to content

bpo-44991: Normalise sqlite3 function and collation callback naming - #28209

Merged
encukou merged 1 commit into
python:mainfrom
erlend-aasland:sqlite-normalise-func
Oct 12, 2021
Merged

bpo-44991: Normalise sqlite3 function and collation callback naming#28209
encukou merged 1 commit into
python:mainfrom
erlend-aasland:sqlite-normalise-func

Conversation

@erlend-aasland

@erlend-aaslanderlend-aasland commented Sep 7, 2021•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@erlend-aasland

erlend-aasland commented Sep 7, 2021

Copy link
Copy Markdown
ContributorAuthor

I forgot these two in GH-28088.

@erlend-aasland

erlend-aasland commented Sep 7, 2021

Copy link
Copy Markdown
ContributorAuthor

cc. @encukou

@erlend-aaslanderlend-aasland changed the title bpo-44991: Normalise function and collation callback namingbpo-44991: Normalise sqlite3 function and collation callback namingSep 7, 2021
@erlend-aasland

erlend-aasland commented Sep 7, 2021

Copy link
Copy Markdown
ContributorAuthor

Reopening to trigger asan test again.

shihai1991
shihai1991 approved these changes Sep 7, 2021
View reviewed changes

@shihai1991shihai1991 left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping consistent code style is fine to me.

@erlend-aasland

erlend-aasland commented Sep 7, 2021

Copy link
Copy Markdown
ContributorAuthor

Keeping consistent code style is fine to me.

Thanks for reviewing!

@github-actions

github-actionsBot commented Oct 8, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actionsgithub-actionsBot added the stale Stale PR or inactive for long period of time. label Oct 8, 2021
encukou
encukou reviewed Oct 12, 2021
View reviewed changes

@encukouencukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't care that strongly about the pysqlite prefix, so I didn't point this out in the earlier review.
But sure, let's make them consistent!

@encukou
encukou merged commit cfb1df3 into python:mainOct 12, 2021
@erlend-aasland
erlend-aasland deleted the sqlite-normalise-func branch October 12, 2021 11:39
@erlend-aaslanderlend-aasland mentioned this pull request May 16, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukouencukouencukou left review comments
@shihai1991shihai1991shihai1991 approved these changes
@berkerpeksagberkerpeksagAwaiting requested review from berkerpeksag

Assignees

No one assigned

Labels

skip newsstaleStale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@erlend-aasland@encukou@shihai1991@the-knights-who-say-ni@bedevere-bot