bpo-45125: Improves pickling docs and tests for `shared_memory` by sobolevn · Pull Request #28294 · python/cpython

sobolevn · 2021-09-11T19:11:29Z

https://bugs.python.org/issue45125

sobolevn · 2021-09-11T19:21:37Z

Oh, I forgot about pickle protocols. ⏳

sobolevn · 2021-09-13T20:04:42Z

@serhiy-storchaka I think that this is ready for the first round of review 👍
Would you, please?
Related #28182

sobolevn · 2021-09-23T08:29:58Z

@serhiy-storchaka friendly ping 🙂

serhiy-storchaka · 2021-09-30T18:07:01Z

It perhaps does not work as you expected. The third argument is a message and usually should be string.

Yes, that's not how I expected this to work! TIL 👍

bedevere-bot · 2021-09-30T18:10:12Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

sobolevn · 2021-10-01T09:06:32Z

@serhiy-storchaka thanks a lot! I've also rebased this onto the latest main.

I have made the requested changes; please review again (to make bot happy).

bedevere-bot · 2021-10-01T09:06:34Z

Thanks for making the requested changes!

@serhiy-storchaka: please review the changes made to this pull request.

sobolevn · 2021-10-01T09:48:09Z

Oups, done 🙂

serhiy-storchaka

LGTM.

miss-islington · 2021-10-01T10:46:02Z

Thanks @sobolevn for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

miss-islington · 2021-10-01T10:46:05Z

Sorry @sobolevn and @serhiy-storchaka, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 746d648d47d12d16c2afedaeff626fc6aaaf6a46 3.10

miss-islington · 2021-10-01T10:46:08Z

Sorry, @sobolevn and @serhiy-storchaka, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 746d648d47d12d16c2afedaeff626fc6aaaf6a46 3.9

miss-islington · 2021-10-01T10:46:34Z

Thanks @sobolevn for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington · 2021-10-01T10:46:35Z

Sorry @sobolevn and @serhiy-storchaka, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 746d648d47d12d16c2afedaeff626fc6aaaf6a46 3.10

miss-islington · 2021-10-01T10:47:05Z

Thanks @sobolevn for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

bedevere-bot · 2021-10-01T10:47:14Z

GH-28675 is a backport of this pull request to the 3.10 branch.

…onGH-28294) (cherry picked from commit 746d648) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

…8294) (cherry picked from commit 746d648) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

sobolevn requested a review from tiran as a code owner September 11, 2021 19:11

the-knights-who-say-ni added the CLA signed label Sep 11, 2021

bedevere-bot added the awaiting review label Sep 11, 2021

serhiy-storchaka requested changes Sep 30, 2021
View reviewed changes

bedevere-bot added awaiting changes and removed awaiting review labels Sep 30, 2021

sobolevn added 3 commits October 1, 2021 12:03

bpo-45125: Improves pickling docs and tests for shared_memory
d4756a7

Adds subTest for each pickle protocol
301df7e

Address review
1bb847c

sobolevn force-pushed the issue-45125 branch from 68b3267 to 1bb847cCompare October 1, 2021 09:03

bedevere-bot removed the awaiting changes label Oct 1, 2021

bedevere-bot added the awaiting change review label Oct 1, 2021

bedevere-bot requested a review from serhiy-storchaka October 1, 2021 09:06

serhiy-storchaka reviewed Oct 1, 2021
View reviewed changes

Comment threadLib/test/_test_multiprocessing.py Outdated
Comment threadLib/test/_test_multiprocessing.py Outdated

Pass protocol
5de9e10

serhiy-storchaka approved these changes Oct 1, 2021
View reviewed changes

bedevere-bot added awaiting merge and removed awaiting change review labels Oct 1, 2021

serhiy-storchaka added needs backport to 3.9 needs backport to 3.10 only security fixes tests Tests in the Lib/test dir labels Oct 1, 2021

serhiy-storchaka merged commit 746d648 into python:mainOct 1, 2021

bedevere-bot removed the awaiting merge label Oct 1, 2021

miss-islington assigned serhiy-storchaka Oct 1, 2021

serhiy-storchaka added needs backport to 3.10 only security fixes and removed needs backport to 3.10 only security fixes labels Oct 1, 2021

bedevere-bot removed the needs backport to 3.10 only security fixes label Oct 1, 2021

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 1, 2021
bpo-45125: Improves pickling docs and tests forshared_memory(pyth…
1a79cfa
…onGH-28294) (cherry picked from commit 746d648) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

miss-islington added a commit that referenced this pull request Oct 1, 2021
bpo-45125: Improves pickling docs and tests forshared_memory(GH-2…
fc3511f
…8294) (cherry picked from commit 746d648) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

serhiy-storchaka removed the needs backport to 3.9 label Nov 10, 2023

serhiy-storchaka removed their assignment Nov 10, 2023

Uh oh!

Uh oh!

Conversation

sobolevn commented Sep 11, 2021• edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sobolevn commented Sep 11, 2021

Uh oh!

sobolevn commented Sep 13, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sobolevn commented Sep 23, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

serhiy-storchakaSep 30, 2021

Choose a reason for hiding this comment

Uh oh!

sobolevnOct 1, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bedevere-bot commented Sep 30, 2021

Uh oh!

sobolevn commented Oct 1, 2021

Uh oh!

bedevere-bot commented Oct 1, 2021

Uh oh!

Uh oh!

Uh oh!

sobolevn commented Oct 1, 2021

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

miss-islington commented Oct 1, 2021

Uh oh!

miss-islington commented Oct 1, 2021

Uh oh!

miss-islington commented Oct 1, 2021

Uh oh!

miss-islington commented Oct 1, 2021

Uh oh!

miss-islington commented Oct 1, 2021

Uh oh!

miss-islington commented Oct 1, 2021

Uh oh!

bedevere-bot commented Oct 1, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sobolevn commented Sep 11, 2021•
edited by bedevere-bot
Loading

sobolevn commented Sep 13, 2021•
edited
Loading