Skip to content

bpo-45156: fixes inifite loop on mock.seal() - #28300

Merged
vstinner merged 7 commits into
python:mainfrom
sobolevn:issue-45156
Sep 14, 2021
Merged

bpo-45156: fixes inifite loop on mock.seal()#28300
vstinner merged 7 commits into
python:mainfrom
sobolevn:issue-45156

Conversation

@sobolevn

@sobolevnsobolevn commented Sep 12, 2021•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@tirkarthi

tirkarthi commented Sep 12, 2021

Copy link
Copy Markdown
Member

cc @mariocj89

corona10
corona10 reviewed Sep 13, 2021
View reviewed changes
Comment threadLib/unittest/mock.py Outdated
corona10
corona10 reviewed Sep 13, 2021
View reviewed changes
Comment threadMisc/NEWS.d/next/Tests/2021-09-13-00-28-17.bpo-45156.8oomV3.rst Outdated
Comment threadMisc/NEWS.d/next/Tests/2021-09-13-00-28-17.bpo-45156.8oomV3.rst Outdated
sobolevnand others added 5 commits September 13, 2021 16:36
@sobolevn@corona10
Update Lib/unittest/mock.py
3c87eea
Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
@sobolevn@corona10
Update Misc/NEWS.d/next/Tests/2021-09-13-00-28-17.bpo-45156.8oomV3.rst
1b70cd4
Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
@sobolevn@corona10
Update Misc/NEWS.d/next/Tests/2021-09-13-00-28-17.bpo-45156.8oomV3.rst
8238aec
Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
@sobolevn
Fixes typo
9fb0b33
@sobolevn
Fixes typo
b156248
@sobolevn

sobolevn commented Sep 13, 2021

Copy link
Copy Markdown
MemberAuthor

@corona10 fixed! Thanks a lot for your help!

mariocj89
mariocj89 approved these changes Sep 14, 2021
View reviewed changes

@mariocj89mariocj89 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this!

@vstinner
vstinner merged commit 7f60c9e into python:mainSep 14, 2021
@vstinnervstinner added the needs backport to 3.10 only security fixes label Sep 14, 2021
@miss-islington

miss-islington commented Sep 14, 2021

Copy link
Copy Markdown
Contributor

Thanks @sobolevn for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Sep 14, 2021

Copy link
Copy Markdown

GH-28326 is a backport of this pull request to the 3.10 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.10 only security fixes label Sep 14, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 14, 2021
@sobolevn@miss-islington
bpo-45156: Fixes inifite loop on unittest.mock.seal() (pythonGH-28300)
50abca7
Fixes infinite loop on unittest.mock.seal() of mocks created by
unittest.create_autospec().
Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
(cherry picked from commit 7f60c9e)
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@miss-islington

miss-islington commented Sep 14, 2021

Copy link
Copy Markdown
Contributor

Thanks @sobolevn for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Sep 14, 2021

Copy link
Copy Markdown

GH-28327 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 14, 2021
@sobolevn@miss-islington
bpo-45156: Fixes inifite loop on unittest.mock.seal() (pythonGH-28300)
2e3c19a
Fixes infinite loop on unittest.mock.seal() of mocks created by
unittest.create_autospec().
Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
(cherry picked from commit 7f60c9e)
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@vstinner

vstinner commented Sep 14, 2021

Copy link
Copy Markdown
Member

Thanks @sobolevn for the fix. I trust @mariocj89 for the review, so I merged the PR ;-)

@sobolevn

sobolevn commented Sep 14, 2021

Copy link
Copy Markdown
MemberAuthor

Thanks everyone!

miss-islington added a commit that referenced this pull request Sep 14, 2021
@miss-islington@sobolevn
bpo-45156: Fixes inifite loop on unittest.mock.seal() (GH-28300)
13257d9
Fixes infinite loop on unittest.mock.seal() of mocks created by
unittest.create_autospec().
Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
(cherry picked from commit 7f60c9e)
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
vstinner pushed a commit that referenced this pull request Sep 14, 2021
@miss-islington@sobolevn
bpo-45156: Fixes inifite loop on unittest.mock.seal() (GH-28300) (GH-…
fd74d26
…28326)
Fixes infinite loop on unittest.mock.seal() of mocks created by
unittest.create_autospec().
Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
(cherry picked from commit 7f60c9e)
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10corona10corona10 left review comments
@cjw296cjw296Awaiting requested review from cjw296cjw296 is a code owner
+1 more reviewer
@mariocj89mariocj89mariocj89 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@sobolevn@tirkarthi@miss-islington@bedevere-bot@vstinner@cjw296@mariocj89@corona10@the-knights-who-say-ni