Uh oh!
There was an error while loading. Please reload this page.
gh-96910: IDLE - make autocomplete winnconfig handler only trigger once - #28332
gh-96910: IDLE - make autocomplete winnconfig handler only trigger once#28332taleinat wants to merge 2 commits into
Conversation
… once Before, this was only enforced on the Windows platform, where multiple calls would result in errors. But logically it is the correct behavior, and it allows simplifying the code as well. Signed-off-by: Tal Einat <532281+taleinat@users.noreply.github.com>
This PR is stale because it has been open for 30 days with no activity. |
PR #28328 for bpo-45193 was closed and a simpler fix applied to 3.11 and 3.10, with a fix for 3.9 pending. This should work for 3.11 and .10. I am thinking of backporting a simplified version to 3.9 and not worry that it is not perfect. Closing and opening to see current results. In msg401802 of bpo-45193, I said "I would rather make a more extensive change than to patch a badly written function for at least the fourth time. I will open an issue for [this] PR and explain later." If I cannot soon remember what I meant, I should apply this after more test and review. |
All commit authors signed the Contributor License Agreement. |
This PR is stale because it has been open for 30 days with no activity. |
Before, this was only enforced on the Windows platform, where multiple calls would result in errors. But logically it is the correct behavior, and it allows simplifying the code as well.
This also includes a minor change to correctly use
platform.system() == "Windows"rather than.startswith("Windows").Note that this requires the fix in PR GH-28328 to work properly on Linux.
Also, note that this has no effect on the position of the completion window while scrolling the editor window, which isn't updated anyways as far as I can tell.