Skip to content

bpo-21302: Add Waitable timer implementation for time.sleep() in Windows - #28341

Closed
Livius90 wants to merge 59 commits into
python:mainfrom
Livius90:bpo-21302
Closed

bpo-21302: Add Waitable timer implementation for time.sleep() in Windows#28341
Livius90 wants to merge 59 commits into
python:mainfrom
Livius90:bpo-21302

Conversation

@Livius90

@Livius90Livius90 commented Sep 14, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor
  • Add Waitable timer object to time.sleep() in Windows operation system.

Some previous pull request history can be found here: #28111

https://bugs.python.org/issue21302

Livius90and others added 30 commits September 1, 2021 14:41
@Livius90
clock_nanosleep() implementation for time.sleep()
55faeb6
clock_nanosleep() is available in Linux which has POSIX 2001.12 or newer
@Livius90
Follow PEP 7 rules in time.sleep()
c7bae3b
PEP 7 rules appled for _PyTime_AsTimespec and _PyTime_AsTimeval error checking in pysleep().
@Livius90
Adjust braces to PEP 7
b3a5c5f
@Livius90
clock_nanosleep check placed after clock_settime
3e07f39
@Livius90
Fix EINTR issue for clock_nanosleep()
e06ba84
In calling clock_nanosleep() EINTR is not stored in errno. Need to use return value of clock_nanosleep()/select() for checking it.
@blurb-it
📜🤖 Added by blurb_it.
6e6d4a3
@Livius90
nanosleep() is available for Unix systems like OSX, FreeBSD
238f073
@Livius90
Update news rst file
b5a5c6e
Unix operating systems eg: Linux, macOS, FreeBSD etc. time.sleep() has a resolution of nanoseconds with using clock_nanosleep() or nanosleep() function.
@Livius90
replace select() with nanosleep()
d064255
In all Unix systems eg: macOS, FreeBSD, Linux etc, nanosleep() is available.
@blurb-it
📜🤖 Added by blurb_it.
b70f187
@Livius90
Fix test_eintr issue for macOS
6ad7c14
@Livius90
Remove news rst and regenerate
74c45e1
@blurb-it
📜🤖 Added by blurb_it.
5988222
@Livius90
Use waitable timer from Win32 for time.sleep() in Windows
129b0a0
Waitable timer is 100 nsec resolution. Now, seconds to nanosec conversion is limited in usec, soon will come the next developing part to improve it in next commit.
@Livius90
Finalized waitable timer for time.sleep() in Windows
d89e13b
Waitable timer resolution is 100 nsec but it is limited to 1 usec by round ceiling, moreover sleep for lower then 1 milisec is not possible in Win32 API.
@blurb-it
📜🤖 Added by blurb_it.
47249f5
@Livius90
Fix macOS build issue
0bf8330
@blurb-it
📜🤖 Added by blurb_it.
085cbed
@Livius90
Final optimization in Waitable timer object implementation
2242638
@blurb-it
📜🤖 Added by blurb_it.
db7851b
@Livius90
revert to original
f7387e8
@Livius90
remove news
a35b0b4
@Livius90
add clock_nanosleep() only
3abf812
@blurb-it
📜🤖 Added by blurb_it.
4cbfde2
@Livius90@vstinner
Update Misc/NEWS.d/next/Library/2021-09-10-00-24-08.bpo-21302.XS_frc.rst
d99c06e
suggested description
Co-authored-by: Victor Stinner <vstinner@python.org>
@Livius90
timeout_abs renaming
117dc62
@Livius90
Simplified HAVE_CLOCK_NANOSLEEP macro blocks
92061f3
@Livius90
remake news
f045047
@blurb-it
📜🤖 Added by blurb_it.
24f9975
@Livius90
Fix err checking
34e3883
vstinner
vstinner reviewed Sep 14, 2021
View reviewed changes
Comment threadModules/timemodule.c Outdated
Comment threadModules/timemodule.c Outdated
Comment threadModules/timemodule.c
Comment threadModules/timemodule.c Outdated
vstinner
vstinner reviewed Sep 16, 2021
View reviewed changes
Comment threadModules/timemodule.c Outdated
vstinner
vstinner reviewed Sep 20, 2021
View reviewed changes
Comment threadModules/timemodule.c Outdated
Comment threadModules/timemodule.c Outdated
Comment threadModules/timemodule.c Outdated
Comment threadMisc/NEWS.d/next/Library/2021-09-15-23-49-21.bpo-21302.KTsR8i.rst Outdated
Comment threadModules/timemodule.c Outdated
Comment threadModules/timemodule.c
@Livius90

Livius90 commented Sep 20, 2021

Copy link
Copy Markdown
ContributorAuthor

Address sanitizer test failed again randomly, @vstinner can you re-run it somehow?

@vstinner

vstinner commented Sep 20, 2021

Copy link
Copy Markdown
Member

Address sanitizer test failed again randomly, @vstinner can you re-run it somehow?

That's the https://bugs.python.org/issue45200 issue.

@vstinner

vstinner commented Sep 20, 2021

Copy link
Copy Markdown
Member

I wrote a different implementation based on this PR, please see my PR #28483.

@vstinner

vstinner commented Sep 22, 2021

Copy link
Copy Markdown
Member

Thanks @Livius90. I merged my PR which is based on yours but also enhance the documentation, contains a bugfix for SIGINT, and has a different implementation.

@Livius90
Livius90 deleted the bpo-21302 branch September 22, 2021 20:11
@Livius90Livius90 mentioned this pull request Sep 22, 2021
Closed
@shankarunnishankarunnimannequin mentioned this pull request Nov 12, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abalkinabalkinAwaiting requested review from abalkin
@pgansslepganssleAwaiting requested review from pgansslepganssle is a code owner
@vstinnervstinnerAwaiting requested review from vstinner

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Livius90@vstinner@the-knights-who-say-ni@bedevere-bot