Uh oh!
There was an error while loading. Please reload this page.
bpo-45229: Remove test_main in many tests - #28405
Merged
serhiy-storchaka merged 1 commit intoSep 19, 2021
Merged
Conversation
serhiy-storchakaforce-pushed
the
regrtest-no-test-main
branch
2 times, most recently
from
September 17, 2021 07:41
c22388d to
a4083e6CompareInstead of explicitly enumerate test classes for run_unittest() use the unittest ability to discover tests. This also makes these tests discoverable and runnable with unittest. load_tests() can be used for dynamic generating tests and adding doctests. setUpModule(), tearDownModule() and addModuleCleanup() can be used for running code before and after all module tests.
serhiy-storchakaforce-pushed
the
regrtest-no-test-main
branch
from
September 17, 2021 12:49
a4083e6 to
dba9b2fCompareserhiy-storchaka
marked this pull request as ready for review
September 17, 2021 12:49
serhiy-storchaka
requested review from
a team, brettcannon, encukou, ericsnowcurrently, ncoghlan, vsajip and warsaw
as code ownersSeptember 17, 2021 12:49
bedevere-bot
commented
Sep 17, 2021
🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit dba9b2f 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
brettcannon
removed their request for review
September 17, 2021 18:17
miss-islington
commented
Sep 19, 2021
Contributor
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
miss-islington
commented
Sep 19, 2021
Contributor
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
miss-islington
commented
Sep 19, 2021
Contributor
Sorry @serhiy-storchaka, I had trouble checking out the |
serhiy-storchaka added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Sep 19, 2021
Instead of explicitly enumerate test classes for run_unittest() use the unittest ability to discover tests. This also makes these tests discoverable and runnable with unittest. load_tests() can be used for dynamic generating tests and adding doctests. setUpModule(), tearDownModule() and addModuleCleanup() can be used for running code before and after all module tests.. (cherry picked from commit 40348ac) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
bedevere-bot
commented
Sep 19, 2021
GH-28455 is a backport of this pull request to the 3.10 branch. |
serhiy-storchaka added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Sep 19, 2021
Instead of explicitly enumerate test classes for run_unittest() use the unittest ability to discover tests. This also makes these tests discoverable and runnable with unittest. load_tests() can be used for dynamic generating tests and adding doctests. setUpModule(), tearDownModule() and addModuleCleanup() can be used for running code before and after all module tests.. (cherry picked from commit 40348ac) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
bedevere-bot
commented
Sep 19, 2021
GH-28456 is a backport of this pull request to the 3.9 branch. |
serhiy-storchaka added a commit
that referenced
this pull request
Sep 19, 2021
Instead of explicitly enumerate test classes for run_unittest() use the unittest ability to discover tests. This also makes these tests discoverable and runnable with unittest. load_tests() can be used for dynamic generating tests and adding doctests. setUpModule(), tearDownModule() and addModuleCleanup() can be used for running code before and after all module tests. (cherry picked from commit 40348ac)
serhiy-storchaka added a commit
that referenced
this pull request
Sep 20, 2021
Instead of explicitly enumerate test classes for run_unittest() use the unittest ability to discover tests. This also makes these tests discoverable and runnable with unittest. load_tests() can be used for dynamic generating tests and adding doctests. setUpModule(), tearDownModule() and addModuleCleanup() can be used for running code before and after all module tests.. (cherry picked from commit 40348ac)
niyas-sait pushed a commit
to niyas-sait/cpython
that referenced
this pull request
Sep 21, 2021
Instead of explicitly enumerate test classes for run_unittest() use the unittest ability to discover tests. This also makes these tests discoverable and runnable with unittest. load_tests() can be used for dynamic generating tests and adding doctests. setUpModule(), tearDownModule() and addModuleCleanup() can be used for running code before and after all module tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of explicitly enumerate test classes for run_unittest()
use the unittest ability to discover tests. This also makes these
tests discoverable and runnable with unittest.
load_tests() can be used for dynamic generating tests and adding
doctests. setUpModule(), tearDownModule() and addModuleCleanup()
can be used for running code before and after all module tests.
https://bugs.python.org/issue45229