Skip to content

bpo-45116: Py_DEBUG ignores Py_ALWAYS_INLINE - #28419

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:always_inline_debug
Sep 17, 2021
Merged

bpo-45116: Py_DEBUG ignores Py_ALWAYS_INLINE#28419
vstinner merged 1 commit into
python:mainfrom
vstinner:always_inline_debug

Conversation

@vstinner

@vstinnervstinner commented Sep 17, 2021•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

If the Py_DEBUG macro is defined, the Py_ALWAYS_INLINE macro does
nothing.

https://bugs.python.org/issue45116

@vstinner
bpo-45116: Py_DEBUG ignores Py_ALWAYS_INLINE
05e7f09
If the Py_DEBUG macro is defined, the Py_ALWAYS_INLINE macro does
nothing.
@vstinner

vstinner commented Sep 17, 2021

Copy link
Copy Markdown
MemberAuthor

Tests / Address sanitizer (pull_request) Failing after 50m — Address sanitizer

It failed with a timeout:

test_error_on_stdio_flush_1 (test.test_multiprocessing_fork.WithProcessesTestProcess) ... Timeout (0:20:00)!

@vstinner

vstinner commented Sep 17, 2021

Copy link
Copy Markdown
MemberAuthor

Tests / Address sanitizer (pull_request) failed again :-(

test_get (test.test_multiprocessing_fork.WithProcessesTestQueue) ... Timeout (0:20:00)!
Thread 0x00007f732679bbc0 (most recent call first):
File "/home/runner/work/cpython/cpython/Lib/multiprocessing/synchronize.py", line 261 in wait
File "/home/runner/work/cpython/cpython/Lib/multiprocessing/synchronize.py", line 349 in wait
File "/home/runner/work/cpython/cpython/Lib/test/_test_multiprocessing.py", line 1001 in test_get

@vstinner

vstinner commented Sep 17, 2021

Copy link
Copy Markdown
MemberAuthor

test_get (test.test_multiprocessing_fork.WithProcessesTestQueue) ... Timeout (0:20:00)!

This issue is tracked by: https://bugs.python.org/issue45200

@vstinner
vstinner merged commit e4044e9 into python:mainSep 17, 2021
@vstinner
vstinner deleted the always_inline_debug branch September 17, 2021 20:46
niyas-sait pushed a commit to niyas-sait/cpython that referenced this pull request Sep 21, 2021
@vstinner@niyas-sait
bpo-45116: Py_DEBUG ignores Py_ALWAYS_INLINE (pythonGH-28419)
f058a97
If the Py_DEBUG macro is defined, the Py_ALWAYS_INLINE macro does
nothing.
@neoneneneonenemannequin mentioned this pull request Apr 10, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner@the-knights-who-say-ni@bedevere-bot