Skip to content

bpo-42222: Improve tests for invalid argument types in randrange() - #29021

Merged
ambv merged 1 commit into
python:mainfrom
serhiy-storchaka:test_randrange_errors
Oct 19, 2021
Merged

bpo-42222: Improve tests for invalid argument types in randrange()#29021
ambv merged 1 commit into
python:mainfrom
serhiy-storchaka:test_randrange_errors

Conversation

@serhiy-storchaka

@serhiy-storchakaserhiy-storchaka commented Oct 18, 2021•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

There were duplicate tests and some tests were removed in previous commit.

https://bugs.python.org/issue42222

@serhiy-storchakaserhiy-storchaka added tests Tests in the Lib/test dir skip news labels Oct 18, 2021
@ambvambv added the needs backport to 3.10 only security fixes label Oct 19, 2021
@ambv
ambv merged commit 5742416 into python:mainOct 19, 2021
@miss-islington

miss-islington commented Oct 19, 2021

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington

miss-islington commented Oct 19, 2021

Copy link
Copy Markdown
Contributor

Sorry @serhiy-storchaka and @ambv, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 574241632bd19e56ed488ee4d8999aefc6a8d7cd 3.10

@ambvambv added needs backport to 3.10 only security fixes and removed needs backport to 3.10 only security fixes labels Oct 19, 2021
@miss-islington

miss-islington commented Oct 19, 2021

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Oct 19, 2021

Copy link
Copy Markdown
Contributor

Sorry, @serhiy-storchaka and @ambv, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 574241632bd19e56ed488ee4d8999aefc6a8d7cd 3.10

@ambvambv removed the needs backport to 3.10 only security fixes label Oct 19, 2021
@ambv

ambv commented Oct 19, 2021

Copy link
Copy Markdown
Contributor

Forget the backport, the original change was in 3.11 actually.

@serhiy-storchaka
serhiy-storchaka deleted the test_randrange_errors branch July 1, 2026 16:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhettingerrhettingerAwaiting requested review from rhettingerrhettinger is a code owner

Assignees

@ambvambv

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@serhiy-storchaka@miss-islington@ambv@the-knights-who-say-ni@bedevere-bot