Skip to content

bpo-45548: Inline _math.c into _math.h - #29181

Closed
brettcannon wants to merge 1 commit into
python:mainfrom
brettcannon:inline-_math
Closed

bpo-45548: Inline _math.c into _math.h#29181
brettcannon wants to merge 1 commit into
python:mainfrom
brettcannon:inline-_math

Conversation

@brettcannon

@brettcannonbrettcannon commented Oct 23, 2021•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@brettcannon
brettcannon requested a review from a team as a code ownerOctober 23, 2021 00:00
@brettcannon
brettcannon marked this pull request as draft October 23, 2021 00:01
@brettcannonbrettcannon mentioned this pull request Oct 23, 2021
Merged
@brettcannon

brettcannon commented Oct 23, 2021

Copy link
Copy Markdown
MemberAuthor

#29179 is an alternative solution to the same problem.

@mdickinson

mdickinson commented Oct 24, 2021

Copy link
Copy Markdown
Member

Any idea what's wrong with the .vcxproj file here, and how to fix it? I don't have a Windows development environment available, and I suspect that the right way to fix is not to edit .vcxproj by hand. (Or is it?)

@tiran

tiran commented Oct 24, 2021

Copy link
Copy Markdown
Member

Any idea what's wrong with the .vcxproj file here, and how to fix it? I don't have a Windows development environment available, and I suspect that the right way to fix is not to edit .vcxproj by hand. (Or is it?)

TBH that's exactly what I did. :) Brett should have access to a Windows box, though.

@tiran

tiran commented Oct 25, 2021

Copy link
Copy Markdown
Member

PR #29179 has landed. Mark suggested to remove all pre-C99 fallbacks except the fixed log1p function. I borrowed your idea and put the body into _math.h. You both are mentioned as co-authors.

@tirantiran closed this Oct 25, 2021
@brettcannon
brettcannon deleted the inline-_math branch October 25, 2021 20:41
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tirantiranAwaiting requested review from tiran
@mdickinsonmdickinsonAwaiting requested review from mdickinson
@erlend-aaslanderlend-aaslandAwaiting requested review from erlend-aaslanderlend-aasland will be requested when the pull request is marked ready for reviewerlend-aasland is a code owner
@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner will be requested when the pull request is marked ready for reviewAA-Turner is a code owner
@emmatypingemmatypingAwaiting requested review from emmatypingemmatyping will be requested when the pull request is marked ready for reviewemmatyping is a code owner
@itamaroitamaroAwaiting requested review from itamaroitamaro will be requested when the pull request is marked ready for reviewitamaro is a code owner

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@brettcannon@mdickinson@tiran@the-knights-who-say-ni@bedevere-bot