Uh oh!
There was an error while loading. Please reload this page.
bpo-45438: format of inspect.Signature with generic builtins - #29212
Merged
Conversation
Use types.GenericAlias in inspect.formatannotation to correctly add type arguments of builtin types to the string representation of Signatures.
This comment has been minimized.
This comment has been minimized.
gvanrossum
approved these changes
Oct 26, 2021
gvanrossum
commented
Oct 26, 2021
Member
@martinitus Please add a news entry. |
ContributorAuthor
Added news entry! How are backports done? - Should I create separate PRs for the 3.10 and 3.9 branches where I cherry pick the two commits?
|
gvanrossum
commented
Oct 27, 2021
Member
Let’s ignore the doc error. Backport are done by a bot. I will merge once the other tests pass. |
miss-islington
commented
Oct 27, 2021
Contributor
Thanks @martinitus for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
bedevere-bot
commented
Oct 27, 2021
@gvanrossum: Please replace |
miss-islington pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 27, 2021
bedevere-bot
commented
Oct 27, 2021
GH-29253 is a backport of this pull request to the 3.10 branch. |
miss-islington pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 27, 2021
bedevere-bot
commented
Oct 27, 2021
GH-29254 is a backport of this pull request to the 3.9 branch. |
miss-islington added a commit
that referenced
this pull request
Oct 27, 2021
Use types.GenericAlias in inspect.formatannotation to correctly add type arguments of builtin types to the string representation of Signatures. Co-authored-by: Martin Rückl <martin.rueckl@codecentric.de> (cherry picked from commit d02ffd1) Co-authored-by: Martin Rueckl <enigma@nbubu.de>
miss-islington added a commit
that referenced
this pull request
Oct 27, 2021
Use types.GenericAlias in inspect.formatannotation to correctly add type arguments of builtin types to the string representation of Signatures. Co-authored-by: Martin Rückl <martin.rueckl@codecentric.de> (cherry picked from commit d02ffd1) Co-authored-by: Martin Rueckl <enigma@nbubu.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isinstance(annotation,types.GenericAlias)ininspect.formatannotationto correctly add type arguments of builtin types to the string representation of Signatures.https://bugs.python.org/issue45438