Uh oh!
There was an error while loading. Please reload this page.
bpo-45613: Set sqlite3.threadsafety dynamically - #29227
Conversation
Use the compile-time selected default SQLite threaded mode to set the DB-API 2.0 attribute 'threadsafety' Mappings: - SQLITE_THREADSAFE=0 => threadsafety=0 - SQLITE_THREADSAFE=1 => threadsafety=3 - SQLITE_THREADSAFE=2 => threadsafety=1
|
bedevere-bot
commented
Oct 29, 2021
🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 396abd4 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
erlend-aasland
commented
Oct 29, 2021
Testing with buildbots to verify that this approach works across different SQLite versions/configurations. I've verified locally that it works with SQLite 3.7.15 (oldest supported), 3.36.0, and current 3.37.0 (dev). |
Uh oh!
There was an error while loading. Please reload this page.
bedevere-bot
commented
Nov 2, 2021
🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 686d70f 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
Uh oh!
There was an error while loading. Please reload this page.
malemburg
left a comment
There was a problem hiding this comment.
I think the patch is good to go as-is, without the additional changes you mentioned in the comments. Thanks, Erlend.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Thanks! There is one change I'd like to make before merging, though: add a |
There was a problem hiding this comment.
LGTM
@malemburg do you have anything else you would like here to be addressed?
Edit: ah, I just saw that you approved before. I am landing this then
erlend-aasland
commented
Nov 3, 2021
Thanks, Marc-Andre & Pablo 🙏🏻 |
Use the compile-time selected default SQLite threaded mode to set the
DB-API 2.0 attribute 'threadsafety' during sqlite3 module initialisation.
SQLite to DB-API mappings:
https://bugs.python.org/issue45613