Skip to content

bpo-45663: Fix is_dataclass() for dataclasses which are subclasses of types.GenericAlias - #29294

Merged
serhiy-storchaka merged 2 commits into
python:mainfrom
serhiy-storchaka:is_dataclass-genericalias
Dec 5, 2021
Merged

bpo-45663: Fix is_dataclass() for dataclasses which are subclasses of types.GenericAlias#29294
serhiy-storchaka merged 2 commits into
python:mainfrom
serhiy-storchaka:is_dataclass-genericalias

Conversation

@serhiy-storchaka

@serhiy-storchakaserhiy-storchaka commented Oct 28, 2021•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@serhiy-storchakaserhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 3.9 needs backport to 3.10 only security fixes labels Oct 28, 2021
@ambvambv added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 2, 2021
@bedevere-bot

bedevere-bot commented Nov 2, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @ambv for commit 3707b67 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 2, 2021
@github-actions

github-actionsBot commented Dec 3, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actionsgithub-actionsBot added the stale Stale PR or inactive for long period of time. label Dec 3, 2021
@serhiy-storchaka
serhiy-storchaka merged commit 446be16 into python:mainDec 5, 2021
@miss-islington

miss-islington commented Dec 5, 2021

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 5, 2021
@serhiy-storchaka@miss-islington
bpo-45663: Fix is_dataclass() for dataclasses which are subclasses of…
66ad403
… types.GenericAlias (pythonGH-29294)
(cherry picked from commit 446be16)
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@serhiy-storchaka
serhiy-storchaka deleted the is_dataclass-genericalias branch December 5, 2021 20:42
@bedevere-bot

bedevere-bot commented Dec 5, 2021

Copy link
Copy Markdown

GH-29925 is a backport of this pull request to the 3.10 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.10 only security fixes label Dec 5, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 5, 2021
@serhiy-storchaka@miss-islington
bpo-45663: Fix is_dataclass() for dataclasses which are subclasses of…
c6ef4d8
… types.GenericAlias (pythonGH-29294)
(cherry picked from commit 446be16)
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot

bedevere-bot commented Dec 5, 2021

Copy link
Copy Markdown

GH-29926 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Dec 5, 2021
@miss-islington@serhiy-storchaka
bpo-45663: Fix is_dataclass() for dataclasses which are subclasses of…
abceb66
… types.GenericAlias (GH-29294)
(cherry picked from commit 446be16)
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington added a commit that referenced this pull request Dec 5, 2021
@miss-islington@serhiy-storchaka
bpo-45663: Fix is_dataclass() for dataclasses which are subclasses of…
1905071
… types.GenericAlias (GH-29294)
(cherry picked from commit 446be16)
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericvsmithericvsmithAwaiting requested review from ericvsmithericvsmith is a code owner

Assignees

No one assigned

Labels

staleStale PR or inactive for long period of time.type-bugAn unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@serhiy-storchaka@bedevere-bot@miss-islington@ambv@the-knights-who-say-ni