Skip to content

bpo-45708: Support underscore separators when formatting Decimal objects - #29438

Closed
mdickinson wants to merge 2 commits into
python:mainfrom
mdickinson:support-underscore-in-decimal-format
Closed

bpo-45708: Support underscore separators when formatting Decimal objects#29438
mdickinson wants to merge 2 commits into
python:mainfrom
mdickinson:support-underscore-in-decimal-format

Conversation

@mdickinson

@mdickinsonmdickinson commented Nov 6, 2021•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

This PR extends formatting for Decimal objects to support underscores as thousands separators (as described in PEP 515). Previously, Decimal only supported commas as thousands separators, while int and float support both commas and underscores.

https://bugs.python.org/issue45708

sobolevn
sobolevn approved these changes Nov 6, 2021
View reviewed changes

@sobolevnsobolevn left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

I looks almost identical to what I did 🙂

@mdickinsonmdickinson added the type-feature A feature request or enhancement label Nov 6, 2021
@tiran

tiran commented Nov 6, 2021

Copy link
Copy Markdown
Member

This will break tests for vendors that de-bundle mpdecimal and use the upstream version. Fedora/CentOS/RHEL are not affected but Debian/Ubuntu use standaline libmpdecimal.

@mdickinson

mdickinson commented Nov 7, 2021

Copy link
Copy Markdown
MemberAuthor

This will break tests [...]

Darn. Thanks, @tiran - my instincts were telling me that we shouldn't modify libmpdec directly, but I failed to figure out why it was a problem.

Closing here; let's continue discussion on the issue.

@mdickinsonmdickinson reopened this Nov 7, 2021
@mdickinson
mdickinson marked this pull request as draft November 7, 2021 09:24
@mdickinson

mdickinson commented Nov 7, 2021•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Re-opening as a proof-of-concept draft PR to show one possible way that we could take this forward without touching libmpdec.

@github-actions

github-actionsBot commented Dec 8, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actionsgithub-actionsBot added the stale Stale PR or inactive for long period of time. label Dec 8, 2021
@belm0belm0 mentioned this pull request Dec 18, 2021
Merged
@mdickinson

mdickinson commented Apr 12, 2022

Copy link
Copy Markdown
MemberAuthor

Closing. This has served its purpose as a POC. I'm not likely to have time to turn it into a production-quality PR any time soon.

@mdickinson
mdickinson deleted the support-underscore-in-decimal-format branch April 12, 2022 16:41
@sndrtjsndrtjmannequin mentioned this pull request Apr 10, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes
@sobolevnsobolevnsobolevn approved these changes
@rhettingerrhettingerAwaiting requested review from rhettinger
@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner will be requested when the pull request is marked ready for reviewAA-Turner is a code owner

Assignees

No one assigned

Labels

awaiting mergestaleStale PR or inactive for long period of time.type-featureA feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mdickinson@tiran@serhiy-storchaka@sobolevn@the-knights-who-say-ni@bedevere-bot