Uh oh!
There was an error while loading. Please reload this page.
bpo-45723: Prepare support for autoconf 2.71 (GH-29441) - #29441
Conversation
bedevere-bot
commented
Nov 7, 2021
🤖 New build scheduled with the buildbot fleet by @tiran for commit 2b2a10ebcb4216c271248e2191c64f29a7a68912 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
tiran
commented
Nov 8, 2021
All changes are based on the output of 2.71's autoupdate tool. |
erlend-aasland
left a comment
There was a problem hiding this comment.
I took a quick look and left some comments.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
tiran
commented
Nov 8, 2021
autoconf 2.71 has deprecated the macro: |
erlend-aasland
commented
Nov 8, 2021
Oh, well 😆 |
tiran
commented
Nov 8, 2021
In autoconf 2.71, |
It seems that we can use |
erlend-aasland
commented
Nov 8, 2021
BTW, we need to make sure we set |
tiran
commented
Nov 8, 2021
autoconf 2.71 no longer defines the variable |
erlend-aasland
left a comment
There was a problem hiding this comment.
LGTM, but I think one NEWS entry is enough ;)
``AC_PROG_EGREP`` should be checked explicitly. ``AC_CONFIG_HEADER`` -> ``AC_CONFIG_HEADERS`` ``AC_USE_SYSTEM_EXTENSIONS`` must be defined before first use of ``AC_LINK`` or ``AC_COMPILE`` macros. ``STDC_HEADERS`` and ``AC_HEADER_TIME`` are obsolete. Signed-off-by: Christian Heimes <christian@python.org>
tiran
commented
Nov 8, 2021
Oops :) I have removed the second entry and rebased the PR. |
AC_PROG_EGREPshould be checked explicitly.AC_CONFIG_HEADER->AC_CONFIG_HEADERSAC_USE_SYSTEM_EXTENSIONSmust be defined before first use ofAC_LINKor
AC_COMPILEmacros.STDC_HEADERSandAC_HEADER_TIMEare obsolete.Signed-off-by: Christian Heimes christian@python.org
https://bugs.python.org/issue45723