Skip to content

bpo-45747: Detect gdbm/dbm dependencies in configure (GH-29467) - #29467

Merged
tiran merged 4 commits into
python:mainfrom
tiran:bpo-45747-dbm
Nov 10, 2021
Merged

bpo-45747: Detect gdbm/dbm dependencies in configure (GH-29467)#29467
tiran merged 4 commits into
python:mainfrom
tiran:bpo-45747-dbm

Conversation

@tiran

@tirantiran commented Nov 8, 2021•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@tirantiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 8, 2021
@bedevere-bot

bedevere-bot commented Nov 8, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @tiran for commit 73438e406438b95b299ddc37d4e8867053fbadfc 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 8, 2021
@tirantiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 8, 2021
@bedevere-bot

bedevere-bot commented Nov 8, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @tiran for commit dad6caa04c8a9ed153341a7ad644cb831f0d02ef 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 8, 2021
@tiran
bpo-45747: Detect gdbm/dbm dependencies in configure
b7f54e6
Signed-off-by: Christian Heimes <christian@python.org>
erlend-aasland
erlend-aasland reviewed Nov 9, 2021
View reviewed changes

@erlend-aaslanderlend-aasland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments about configure.ac (I haven't looked at the setup.py changes yet)

Comment threadconfigure.ac
Comment on lines +3128 to +3130
AC_CHECK_LIB([ndbm], [dbm_open])
LIBS="$LIBS_SAVE"
AC_CHECK_LIB([gdbm_compat], [dbm_open])

@erlend-aaslanderlend-aaslandNov 9, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we can fold these into:

Suggested change
AC_CHECK_LIB([ndbm], [dbm_open])
LIBS="$LIBS_SAVE"
AC_CHECK_LIB([gdbm_compat], [dbm_open])
AC_SEARCH_LIBS([dbm_open], [ndbm gdbm_compat])

@tirantiranNov 9, 2021

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AC_SEARCH_LIBS() does not create HAVE_LIBFOO entries.

@erlend-aaslanderlend-aaslandNov 9, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that's unfortunate.

Comment threadconfigure.ac
Comment threadconfigure.ac Outdated
Comment threadconfigure.ac Outdated
tiranand others added 3 commits November 9, 2021 20:05
@tiranErlend Egeberg Aasland
Update configure.ac
d47a556
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@tiranErlend Egeberg Aasland
Update configure.ac
6d47d3f
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@tiran
Explain why AS_UNSET is needed here
dc605e8
erlend-aasland
erlend-aasland approved these changes Nov 10, 2021
View reviewed changes

@erlend-aaslanderlend-aasland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is it worth it to document the USE_* defines in whatsnew?

@tiran

tiran commented Nov 10, 2021

Copy link
Copy Markdown
MemberAuthor

LGTM. Is it worth it to document the USE_* defines in whatsnew?

It's an internal detailed of the build system and not user-facing.

@tirantiran changed the title bpo-45747: Detect gdbm/dbm dependencies in configurebpo-45747: Detect gdbm/dbm dependencies in configure (GH-29467)Nov 10, 2021
@tiran
tiran merged commit 0a9f695 into python:mainNov 10, 2021
@tiran
tiran deleted the bpo-45747-dbm branch November 10, 2021 19:26
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
@tiranErlend Egeberg Aasland@remykarem
bpo-45747: Detect gdbm/dbm dependencies in configure (pythonGH-29467)
5dbd52c
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
remykarem pushed a commit to remykarem/cpython that referenced this pull request Jan 30, 2022
@tiranErlend Egeberg Aasland@remykarem
bpo-45747: Detect gdbm/dbm dependencies in configure (pythonGH-29467)
5077e64
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@ambvambv mentioned this pull request May 3, 2022
Merged
@tirantiran mentioned this pull request Apr 10, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tiran@bedevere-bot@erlend-aasland@the-knights-who-say-ni