bpo-45573: Move mandatory core modules to Modules/Setup.bootstrap (GH-29616)

[tiran]

Signed-off-by: Christian Heimes christian@python.org

https://bugs.python.org/issue45573

[erlend-aasland]

This is a nice improvement. Not all modules that #define Py_BUILD_CORE_MODULE are included in Modules/Setup.core. Is Modules/Setup.builtin a more "correct" name?

Modules that define Py_BUILD_CORE_MODULE

$ grep -r "#.*define.*Py_BUILD_CORE_MODULE" Modules | sort
Modules/_abc.c:# define Py_BUILD_CORE_MODULE 1
Modules/_asynciomodule.c:# define Py_BUILD_CORE_MODULE 1
Modules/_blake2/blake2b_impl.c:# define Py_BUILD_CORE_MODULE 1
Modules/_blake2/blake2module.c:# define Py_BUILD_CORE_MODULE 1
Modules/_blake2/blake2s_impl.c:# define Py_BUILD_CORE_MODULE 1
Modules/_ctypes/_ctypes.c:# define Py_BUILD_CORE_MODULE 1
Modules/_ctypes/callbacks.c:# define Py_BUILD_CORE_MODULE 1
Modules/_ctypes/cfield.c:# define Py_BUILD_CORE_MODULE 1
Modules/_ctypes/stgdict.c:# define Py_BUILD_CORE_MODULE 1
Modules/_cursesmodule.c:# define Py_BUILD_CORE_MODULE 1
Modules/_datetimemodule.c:# define Py_BUILD_CORE_MODULE 1
Modules/_decimal/_decimal.c:# define Py_BUILD_CORE_MODULE 1
Modules/_hashopenssl.c:# define Py_BUILD_CORE_MODULE 1
Modules/_heapqmodule.c:# define Py_BUILD_CORE_MODULE 1
Modules/_json.c:# define Py_BUILD_CORE_MODULE 1
Modules/_lsprof.c:# define Py_BUILD_CORE_MODULE 1
Modules/_pickle.c:# define Py_BUILD_CORE_MODULE 1
Modules/_posixsubprocess.c:# define Py_BUILD_CORE_MODULE 1
Modules/_queuemodule.c:# define Py_BUILD_CORE_MODULE 1
Modules/_randommodule.c:# define Py_BUILD_CORE_MODULE 1
Modules/_sha3/sha3module.c:# define Py_BUILD_CORE_MODULE 1
Modules/_struct.c:# define Py_BUILD_CORE_MODULE 1
Modules/_testinternalcapi.c:# define Py_BUILD_CORE_MODULE 1
Modules/_testmultiphase.c:# define Py_BUILD_CORE_MODULE 1
Modules/_xxsubinterpretersmodule.c:# define Py_BUILD_CORE_MODULE 1
Modules/_zoneinfo.c:# define Py_BUILD_CORE_MODULE 1
Modules/arraymodule.c:# define Py_BUILD_CORE_MODULE 1
Modules/binascii.c:# define Py_BUILD_CORE_MODULE 1
Modules/cmathmodule.c:# define Py_BUILD_CORE_MODULE 1
Modules/mathmodule.c:# define Py_BUILD_CORE_MODULE 1
Modules/md5module.c:# define Py_BUILD_CORE_MODULE 1
Modules/sha1module.c:# define Py_BUILD_CORE_MODULE 1
Modules/sha256module.c:# define Py_BUILD_CORE_MODULE 1
Modules/sha512module.c:# define Py_BUILD_CORE_MODULE 1
Modules/unicodedata.c:# define Py_BUILD_CORE_MODULE 1

[erlend-aasland]

Why the alias?

[tiran]

This is a nice improvement. Not all modules that #define Py_BUILD_CORE_MODULE are included in Modules/Setup.core. Is Modules/Setup.builtin a more "correct" name?

The term core is overloaded. I have not found a better term, though.

Py_BUILD_CORE_MODULE enables some private APIs that not available to 3rd party extension modules. The flag is orthogonal to static / shared state. You can build a shared C extension that uses core module APIs.

Setup.builtin does not fit well either. Other modules can be build as builtin modules, too. Setup.mandatory is also incorrect. Some modules like _abc could be build as shared extensions. Maybe Setup.bootstrap ?

[erlend-aasland]

Yeah, Setup.bootstrap sounds like the best candidate.

[erlend-aasland]

Great! LGTM