Skip to content

bpo-45847: Port fcntl to Py_STDLIB_MOD (GH-29696) - #29696

Merged
tiran merged 4 commits into
python:mainfrom
erlend-aasland:ac-simple-mods/fcntl
Nov 22, 2021
Merged

bpo-45847: Port fcntl to Py_STDLIB_MOD (GH-29696)#29696
tiran merged 4 commits into
python:mainfrom
erlend-aasland:ac-simple-mods/fcntl

Conversation

@erlend-aasland

@erlend-aaslanderlend-aasland commented Nov 22, 2021•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@erlend-aasland

erlend-aasland commented Nov 22, 2021

Copy link
Copy Markdown
ContributorAuthor

I added checks for sys/ioctl.h and fcntl.h. Probably not needed, OTOH it doesn't hurt either. Also simplified some of the AC checks for fcntl.

tiran
tiran reviewed Nov 22, 2021
View reviewed changes
Comment threadconfigure.ac Outdated
Erlend Egeberg Aasland@tiran
Address review: consistent formatting
e1e1e2a
Co-authored-by: Christian Heimes <christian@python.org>
@erlend-aasland

erlend-aasland commented Nov 22, 2021

Copy link
Copy Markdown
ContributorAuthor

Reopen to retrigger flakey asyncio test on windows.

@tirantiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 22, 2021
@bedevere-bot

bedevere-bot commented Nov 22, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @tiran for commit b143948 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 22, 2021
@tirantiran changed the title bpo-45847: Port fcntl to Py_STDLIB_MODbpo-45847: Port fcntl to Py_STDLIB_MOD (GH-29696)Nov 22, 2021
@tiran
tiran merged commit 5b946ca into python:mainNov 22, 2021
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
Erlend Egeberg Aasland@tiran@remykarem
bpo-45847: Port fcntl to Py_STDLIB_MOD (pythonGH-29696)
322a8b0
Co-authored-by: Christian Heimes <christian@python.org>
@tirantiran mentioned this pull request Apr 14, 2022
Closed
jefferyto
jefferyto reviewed May 25, 2023
View reviewed changes
Comment threadconfigure.ac
@erlend-aasland
erlend-aasland deleted the ac-simple-mods/fcntl branch May 25, 2023 07:11
@erlend-aaslanderlend-aasland mentioned this pull request Jun 2, 2023
Merged
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Jun 2, 2023
@erlend-aasland
pythongh-90005: Don't link with libbsd if not needed
20add4f
Restore pre pythongh-29696 behaviour
erlend-aasland added a commit that referenced this pull request Jun 6, 2023
@erlend-aasland
gh-90005: Don't link with libbsd if not needed (#105236)
e01c4de
The regression was introduced with commit 5b946ca.
Restore pre gh-29696 behaviour.
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Jun 6, 2023
@erlend-aasland
[3.12]pythongh-90005: Don't link with libbsd if not needed (python#1…
bdd2b89
…05236)
The regression was introduced with commit 5b946ca.
Restore pre pythongh-29696 behaviour.
This was referenced Jun 6, 2023
Merged
Merged
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Jun 6, 2023
@erlend-aasland
[3.11]pythongh-90005: Don't link with libbsd if not needed (python#1…
a8c9f08
…05236)
The regression was introduced with commit 5b946ca.
Restore pre pythongh-29696 behaviour.
erlend-aasland added a commit that referenced this pull request Jun 6, 2023
@erlend-aasland
[3.12]gh-90005: Don't link with libbsd if not needed (#105236) (#105360
6f3a4fd
)
The regression was introduced with commit 5b946ca.
Restore pre gh-29696 behaviour.
erlend-aasland added a commit that referenced this pull request Jun 6, 2023
@erlend-aasland
[3.11]gh-90005: Don't link with libbsd if not needed (#105236) (#105359
b8d3bb7
)
The regression was introduced with commit 5b946ca.
Restore pre gh-29696 behaviour.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tirantirantiran approved these changes
+1 more reviewer
@jefferytojefferytojefferyto left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erlend-aasland@bedevere-bot@jefferyto@tiran