Skip to content

bpo-45847: Port nis module to PY_STDLIB_MOD (GH-29699) - #29699

Merged
tiran merged 2 commits into
python:mainfrom
tiran:bpo-45847-nis
Nov 22, 2021
Merged

bpo-45847: Port nis module to PY_STDLIB_MOD (GH-29699)#29699
tiran merged 2 commits into
python:mainfrom
tiran:bpo-45847-nis

Conversation

@tiran

@tirantiran commented Nov 22, 2021

Copy link
Copy Markdown
Member

@tiran
tiran marked this pull request as ready for review November 22, 2021 11:17
@tirantiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 22, 2021
@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @tiran for commit 3043b762c9cbcb0500de5d9e19cb4139e1457d40 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 22, 2021
@tirantiran changed the title bpo-45847: Port nis module to PY_STDLIB_MOD_SIMPLEbpo-45847: Port nis module to PY_STDLIB_MODNov 22, 2021
Comment threadconfigure.ac Outdated
@tirantiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 22, 2021
@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @tiran for commit c6c687160b4ad830a55235581e6515f36ffe27cd 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 22, 2021
Signed-off-by: Christian Heimes <christian@python.org>
@MODULE__RANDOM_TRUE@_random _randommodule.c
@MODULE__TYPING_TRUE@_typing _typingmodule.c
@MODULE__XXSUBINTERPRETERS_TRUE@_xxsubinterpreters __xxsubinterpretersmodule.c
@MODULE__XXSUBINTERPRETERS_TRUE@_xxsubinterpreters _xxsubinterpretersmodule.c

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erlend-aasland I'm sneaking in this typo fix, too.

Comment threadconfigure.ac

PY_STDLIB_MOD([_decimal], [], [], [$LIBMPDEC_CFLAGS], [$LIBMPDEC_LDFLAGS])
PY_STDLIB_MOD([nis],
[], [test "$have_nis" = yes -a "$ac_cv_header_rpc_rpc_h" = yes],

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICS, header check for rpc/rpc.h is missing.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's right there:

AS_VAR_IF([have_nis], [yes], [
WITH_SAVE_ENV([
CPPFLAGS="$LIBNSL_CFLAGS $CFLAGS"
AC_CHECK_HEADERS([rpc/rpc.h])
])
])

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦🏻

@tirantiran changed the title bpo-45847: Port nis module to PY_STDLIB_MODbpo-45847: Port nis module to PY_STDLIB_MOD (GH-29699)Nov 22, 2021
@tiran
tiran merged commit c6dec7e into python:mainNov 22, 2021
@tiran
tiran deleted the bpo-45847-nis branch November 22, 2021 14:18
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@tiran@bedevere-bot@erlend-aasland@the-knights-who-say-ni