Skip to content

bpo-45873: Restore Python 3.6 compatibility (GH-29730) - #29730

Merged
tiran merged 4 commits into
python:mainfrom
tiran:bpo-45873-py36
Nov 23, 2021
Merged

bpo-45873: Restore Python 3.6 compatibility (GH-29730)#29730
tiran merged 4 commits into
python:mainfrom
tiran:bpo-45873-py36

Conversation

@tiran

@tirantiran commented Nov 23, 2021

Copy link
Copy Markdown
Member

https://bugs.python.org/issue45873

Automerge-Triggered-By: GH:tiran

@tirantiran added skip news 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Nov 23, 2021
@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @tiran for commit f5818e6 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 23, 2021

@gvanrossumgvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but is it even worth testing for 3.7+? Why not always take the slow path?

@tirantiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 23, 2021
@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @tiran for commit cb24cf5 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 23, 2021
@tiran

Copy link
Copy Markdown
MemberAuthor

LGTM, but is it even worth testing for 3.7+? Why not always take the slow path?

I left the old implementation in because it's more readable. The fast path is now in a doc string for future reference.

I also added more debug code to configure to figure out what is going on on the Debian buildbot.

@tiran

Copy link
Copy Markdown
MemberAuthor

Closing and reopening to retrigger Azure.

@tirantiran closed this Nov 23, 2021
@tirantiran reopened this Nov 23, 2021

@gvanrossumgvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Why do we even bother with "python3 python"? For weird platforms that have only one of those but it happens to be 3.6 or better?)

@tiran

Copy link
Copy Markdown
MemberAuthor

(Why do we even bother with "python3 python"? For weird platforms that have only one of those but it happens to be 3.6 or better?)

I don't know and kept python 3 python just in case.

Comment threadTools/scripts/deepfreeze.py Outdated
@tiran

tiran commented Nov 23, 2021

Copy link
Copy Markdown
MemberAuthor

Broke Azure tests are likely caused by GH-28612GH-29488.

Co-authored-by: Guido van Rossum <gvanrossum@gmail.com>

@gvanrossumgvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-)

@gvanrossum

Copy link
Copy Markdown
Member

Broke Azure tests are likely caused by GH-28612.

How? That PR was closed without merging. And if there was a cause outside this PR why would it not have failed before (e.g. when I submitted #29717)?

Are you suggesting there are some cached files from running that PR present?

@miss-islington

Copy link
Copy Markdown
Contributor

@tiran: Status check is done, and it's a failure ❌ .

@tiran

tiran commented Nov 23, 2021

Copy link
Copy Markdown
MemberAuthor

I confused GH-28612 with GH-29488. Both are for bpo-39026.

This PR was created after @vstinner merged GH-29488. That's why my PR has failing Azure tests and your PR did not.

@tirantiran changed the title bpo-45873: Restore Python 3.6 compatibilitybpo-45873: Restore Python 3.6 compatibility (GH-29730)Nov 23, 2021
@tiran
tiran merged commit f840398 into python:mainNov 23, 2021
@tiran
tiran deleted the bpo-45873-py36 branch November 23, 2021 20:36
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
Co-authored-by: Guido van Rossum <gvanrossum@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@tiran@bedevere-bot@gvanrossum@miss-islington@the-knights-who-say-ni