Uh oh!
There was an error while loading. Please reload this page.
bpo-45847: Port _ctypes partly to PY_STDLIB_MOD (GH-29747) - #29747
Merged
Conversation
bedevere-bot
commented
Nov 24, 2021
🤖 New build scheduled with the buildbot fleet by @tiran for commit e39443e8c0770623ca81d8b17ff3317d2010361c 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
tiran
commented
Nov 24, 2021
MemberAuthor
@ned-deily@ronaldoussoren I need your help with the macOS part of the patch. |
ronaldoussoren
commented
Nov 24, 2021
Contributor
Which parts do you need help with? It should be possible to move the macOS logic to configure.ac, although I'm a bit hazy at the moment about why some of the logic is there and some of the logic might be broken (in particular the code that sets USING_APPLE_OS_LIBFFI seems dodgy when self.use_system_libffi is false). I can look into this at the end of the week. BTW. Feel free to ping me directly, I don't regularly look at GitHub messages and only noticed your question promptly because Mail.app claimed it was junk mail. |
tiran
marked this pull request as ready for review
November 28, 2021 12:07
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Christian Heimes <christian@python.org>
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
pablogsal
commented
Dec 7, 2021
Member
@tiran After this PR, the gentoo builder is failing: https://buildbot.python.org/all/#/builders/58/builds/1217 |
tiran added a commit
to tiran/cpython
that referenced
this pull request
Dec 7, 2021
…)" This reverts commit 4045392.
tiran added a commit
that referenced
this pull request
Dec 7, 2021
tiran added a commit
to tiran/cpython
that referenced
this pull request
Jun 26, 2022
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Christian Heimes christian@python.org
https://bugs.python.org/issue45847