Uh oh!
There was an error while loading. Please reload this page.
bpo-45019: Cleanup module freezing and deepfreeze - #29772
Conversation
kumaraditya303
commented
Nov 25, 2021
cc @gvanrossum |
gvanrossum
left a comment
There was a problem hiding this comment.
Without looking carefully yet, I think I like your cleanup of freeze_modules.py, but not the rename of the deepfreeze directory. Can you undo the latter and just focus on improving the script?
EDIT: @gvanrossum done |
gvanrossum
left a comment
There was a problem hiding this comment.
This is great. I have a few nits.
I also wonder if there aren't more improvements we can make, e.g. use relative paths throughout the code, rather than computing absolute paths and then making them relative for the generated code again.
Oh, and it would be nice to be able to freeze some submodules in a package but not all of them -- e.g. I'd like to freeze encodings/{__init__,utf_8,aliases}.py but not the remaining 100 submodules in that package.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Freeze encoding here #29788 |
gvanrossum
left a comment
There was a problem hiding this comment.
Looks good for this phase! I'll merge this now. Then you can work on e.g. changes groups of functions to classes and partially freezing encodings.
bedevere-bot
commented
Nov 26, 2021
@gvanrossum: Please replace |
Thanks @gvanrossum This was my first contribution to cpython, earlier was just a typo fix, glad that you merged it :). |
gvanrossum
commented
Nov 26, 2021
Thanks Kumar for cleaning up our mess! :-) I am looking forward to seeing more from you. |
https://bugs.python.org/issue45019