Skip to content

bpo-45881: configure --with-freeze-module --with-build-python (GH-29835) - #29835

Merged
tiran merged 7 commits into
python:mainfrom
tiran:bpo-45881-cross-freeze
Nov 29, 2021
Merged

bpo-45881: configure --with-freeze-module --with-build-python (GH-29835)#29835
tiran merged 7 commits into
python:mainfrom
tiran:bpo-45881-cross-freeze

Conversation

@tiran

@tirantiran commented Nov 29, 2021•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Make cross compiling more convenient. configure now takes
--with-freeze-module and --with-build-python arguments. There is
no need pass FREEZE_MODULE and PYTHON_FOR_BUILD env vars any
more.

Signed-off-by: Christian Heimes christian@python.org

https://bugs.python.org/issue45881

@tiran
tiran marked this pull request as draft November 29, 2021 11:46
@tiran

tiran commented Nov 29, 2021•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

@ethanhs

This changeset makes our configure call easier: emconfigure ../../configure -C --with-freeze-module=$(pwd)/../build/Programs/_freeze_module --with-build-python=$(pwd)/../build/python

  • improve help strings
  • write documentation
  • adds blurb

erlend-aasland
erlend-aasland approved these changes Nov 29, 2021
View reviewed changes
Comment threadconfigure.ac Outdated
emmatyping
emmatyping reviewed Nov 29, 2021
View reviewed changes

@emmatypingemmatyping left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a bunch of minor nits but overall this looks good! I also think we should be strict in checking that the Python version used for _freeze_module is the same as the host Python.

Comment threadconfigure.ac Outdated
Comment threadconfigure.ac Outdated
Comment threadconfigure.ac Outdated
Comment threadconfigure.ac Outdated
Comment threadconfigure.ac Outdated
Comment threadconfigure.ac Outdated
Comment threadconfigure.ac Outdated
@tiran
tiranforce-pushed the bpo-45881-cross-freeze branch from 772abec to 7fbc2b4CompareNovember 29, 2021 15:30
@tiran
tiran marked this pull request as ready for review November 29, 2021 15:31
tiranand others added 7 commits November 29, 2021 16:34
@tiran
bpo-45881: configure --with-freeze-module --with-build-python
2a31f90
Make cross compiling more convenient. configure now takes
``--with-freeze-module`` and ``--with-build-python`` arguments. There is
no need pass ``FREEZE_MODULE`` and ``PYTHON_FOR_BUILD`` env vars any
more.
Signed-off-by: Christian Heimes <christian@python.org>
@tiranErlend Egeberg Aasland
Rename arg to freeze-module
0a8c339
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@tiran@emmatyping
it's called _freeze_module
47f9e2e
Co-authored-by: Ethan Smith <ethan@ethanhs.me>
@tiran@emmatyping
Update configure.ac
ad8c9da
Co-authored-by: Ethan Smith <ethan@ethanhs.me>
@tiran@emmatyping
Update configure.ac
deab8e9
Co-authored-by: Ethan Smith <ethan@ethanhs.me>
@tiran
More docs
04d8eb0
@tiran
blurb
e4eff12
@tiran
tiranforce-pushed the bpo-45881-cross-freeze branch from 158a573 to e4eff12CompareNovember 29, 2021 15:34
@tirantiran changed the title bpo-45881: configure --with-freeze-module --with-build-pythonbpo-45881: configure --with-freeze-module --with-build-python (GH-29835)Nov 29, 2021
@tiran
tiran merged commit 992565f into python:mainNov 29, 2021
@tiran
tiran deleted the bpo-45881-cross-freeze branch November 29, 2021 16:23
tiran added a commit to tiran/python-wasm that referenced this pull request Nov 29, 2021
@tiran
Use new --with-freeze-module and --with-build-python options
7f69833
See: python/cpython#29835
Signed-off-by: Christian Heimes <christian@python.org>
@tirantiran mentioned this pull request Nov 29, 2021
Merged
shihai1991 added a commit to shihai1991/cpython that referenced this pull request Dec 1, 2021
@shihai1991
Merge branch 'main' into bpo_44133
6edb6f5
* main: (21 commits)
bpo-45876: Have stdev() also use decimal specific square root. (pythonGH-29869)
bpo-45876: Correctly rounded stdev() and pstdev() for the Decimal case (pythonGH-29828)
bpo-45711: Change exc_info related APIs to derive type and traceback from the exception instance (pythonGH-29780)
bpo-30533:Add function inspect.getmembers_static that does not call properties or dynamic properties. (python#20911)
bpo-45476: Disallow using asdl_seq_GET() as l-value (pythonGH-29866)
bpo-45476: Add _Py_RVALUE() macro (pythonGH-29860)
bpo-33381: [doc] strftime's %f option may pad zeros on the left or the right (pythonGH-29801)
Fix EncodingWarning in Tools/freeze/test/freeze.py (pythonGH-29742)
no-issue: remove unused import from test_graphlib.py (pythonGH-29853)
bpo-45931: Prevent Directory.Build.props/targets from leaking from directories above the repo when building on Windows (pythonGH-29854)
bpo-45653: fix test_embed on windows (pythonGH-29814)
bpo-45917: Add math.exp2() method - return 2 raised to the power of x (pythonGH-29829)
bpo-43905: Expand dataclasses.astuple() and asdict() docs (pythonGH-26154)
bpo-44391: Remove unused argument from a varargs call. (pythonGH-29843)
bpo-45881: configure --with-freeze-module --with-build-python (pythonGH-29835)
bpo-45847: PY_STDLIB_MOD_SIMPLE now checks py_stdlib_not_available (pythonGH-29844)
bpo-45828: Use unraisable exceptions within sqlite3 callbacks (FH-29591)
bpo-40280: Emscripten systems use .wasm suffix by default (pythonGH-29842)
bpo-45723: Sort the grand AC_CHECK_HEADERS check (pythonGH-29846)
bpo-45847: Make socket module conditional (pythonGH-29769)
...
shihai1991 added a commit to shihai1991/cpython that referenced this pull request Dec 1, 2021
@shihai1991
Merge branch 'main' into bpo_44133
b71b124
* main: (21 commits)
bpo-45876: Have stdev() also use decimal specific square root. (pythonGH-29869)
bpo-45876: Correctly rounded stdev() and pstdev() for the Decimal case (pythonGH-29828)
bpo-45711: Change exc_info related APIs to derive type and traceback from the exception instance (pythonGH-29780)
bpo-30533:Add function inspect.getmembers_static that does not call properties or dynamic properties. (python#20911)
bpo-45476: Disallow using asdl_seq_GET() as l-value (pythonGH-29866)
bpo-45476: Add _Py_RVALUE() macro (pythonGH-29860)
bpo-33381: [doc] strftime's %f option may pad zeros on the left or the right (pythonGH-29801)
Fix EncodingWarning in Tools/freeze/test/freeze.py (pythonGH-29742)
no-issue: remove unused import from test_graphlib.py (pythonGH-29853)
bpo-45931: Prevent Directory.Build.props/targets from leaking from directories above the repo when building on Windows (pythonGH-29854)
bpo-45653: fix test_embed on windows (pythonGH-29814)
bpo-45917: Add math.exp2() method - return 2 raised to the power of x (pythonGH-29829)
bpo-43905: Expand dataclasses.astuple() and asdict() docs (pythonGH-26154)
bpo-44391: Remove unused argument from a varargs call. (pythonGH-29843)
bpo-45881: configure --with-freeze-module --with-build-python (pythonGH-29835)
bpo-45847: PY_STDLIB_MOD_SIMPLE now checks py_stdlib_not_available (pythonGH-29844)
bpo-45828: Use unraisable exceptions within sqlite3 callbacks (FH-29591)
bpo-40280: Emscripten systems use .wasm suffix by default (pythonGH-29842)
bpo-45723: Sort the grand AC_CHECK_HEADERS check (pythonGH-29846)
bpo-45847: Make socket module conditional (pythonGH-29769)
...
@emmatypingemmatyping mentioned this pull request Dec 2, 2021
Closed
This was referenced Apr 11, 2022
Open
Closed
@tirantiran mentioned this pull request Apr 10, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes
@emmatypingemmatypingemmatyping approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tiran@emmatyping@erlend-aasland@the-knights-who-say-ni@bedevere-bot