Skip to content

bpo-40280: Emscripten with_ensurepip=no, second attempt (GH-29884) - #29884

Merged
tiran merged 1 commit into
python:mainfrom
tiran:bpo-40280-ensurepip2
Dec 1, 2021
Merged

bpo-40280: Emscripten with_ensurepip=no, second attempt (GH-29884)#29884
tiran merged 1 commit into
python:mainfrom
tiran:bpo-40280-ensurepip2

Conversation

@tiran

@tirantiran commented Dec 1, 2021•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@tiran

tiran commented Dec 1, 2021

Copy link
Copy Markdown
MemberAuthor

I forgot to remove --with-ensurepip=no from the build script when I tested the first patch.

@brettcannon

brettcannon commented Dec 1, 2021

Copy link
Copy Markdown
Member

Shows how valuable my reviews are 😅

@tiran

tiran commented Dec 1, 2021

Copy link
Copy Markdown
MemberAuthor

Shows how valuable my reviews are sweat_smile

We need CI :)

@tirantiran changed the title bpo-40280: Emscripten with_ensurepip=no, second attemptbpo-40280: Emscripten with_ensurepip=no, second attempt (GH-29884)Dec 1, 2021
@tiran
tiran merged commit 309110f into python:mainDec 1, 2021
@tiran
tiran deleted the bpo-40280-ensurepip2 branch December 1, 2021 22:16
@tirantiran mentioned this pull request Dec 2, 2021
Closed
@SimonBiggsSimonBiggsmannequin mentioned this pull request Jun 7, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannonbrettcannonbrettcannon approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tiran@brettcannon@the-knights-who-say-ni@bedevere-bot