Uh oh!
There was an error while loading. Please reload this page.
bpo-40280: Add Tools/wasm with helpers for cross building (GH-29984) - #29984
Conversation
3305617 to
877bb04Compare877bb04 to
f65a480Comparetiran
commented
Dec 13, 2021
|
emmatyping
left a comment
There was a problem hiding this comment.
This will definitely make experimenting with Emscripten based CPython a lot easier!
I have a few suggestions/comments but overall this looks good.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
emmatyping
commented
Dec 13, 2021
The binary size looks really great! Though with the number of things disabled, it will probably grow over time... |
a3797c0 to
6a103d9Comparetiran
commented
Dec 14, 2021
With I'm able to shrink the core to about 6 MB The The largest 25 files are: @brettcannon now is a good time to discuss what modules belong in a minimum stdlib. |
emmatyping
commented
Dec 14, 2021
Wow that's a great reduction in size! I played with thin lto and for some reason it greatly increases the binary size (to 21MB!). I guess inlining makes the build a lot bigger. One other idea I had which gives small gains in binary size is compiling with -Os, which seems to not make much of a difference vs -Oz. |
tiran
commented
Dec 14, 2021
Actually it is less. I think I introduced a regression in GH-30001. makesetup is dropping too many modules from the final binary. |
59d8c8e to
218aef5CompareCo-authored-by: Ethan Smith <ethan@ethanhs.me>
218aef5 to
f933b91CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| ## wasm32-emscripten build | ||
| Cross compiling to wasm32-emscripten platform needs [Emscripten](https://emscripten.org/) | ||
| tool chain and a build Python interpreter. |
There was a problem hiding this comment.
| tool chain and a build Python interpreter. | |
| tool chain and a built Python interpreter. |
There was a problem hiding this comment.
build here is I believe a reference to the autotools/configure --build argument. (Same for line 11 below).
There was a problem hiding this comment.
That is correct. In lack of a better term I introduced the term "build Python"/
There was a problem hiding this comment.
My brain just keeps reading "build" as a verb instead of an adjective. 😄
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Brett Cannon <brett@python.org>
Co-authored-by: Brett Cannon <brett@python.org>
CPython upstream now has a config.site for WASM `and make python.html`. See: python/cpython#29984 Signed-off-by: Christian Heimes <christian@python.org>
https://bugs.python.org/issue40280