Skip to content

bpo-46005: add note about setuptools to Doc/extending/building.rst - #30062

Closed
sobolevn wants to merge 2 commits into
python:mainfrom
sobolevn:issue-46005
Closed

bpo-46005: add note about setuptools to Doc/extending/building.rst#30062
sobolevn wants to merge 2 commits into
python:mainfrom
sobolevn:issue-46005

Conversation

@sobolevn

@sobolevnsobolevn commented Dec 11, 2021

Copy link
Copy Markdown
Member

@bedevere-botbedevere-bot added the docs Documentation in the Doc dir label Dec 11, 2021
@AlexWaygoodAlexWaygood added the needs backport to 3.10 only security fixes label Dec 13, 2021

@merwokmerwok left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I would remove the news snippet. It will not really provide value when collected in a NEWS document (unless I’ve missed recent conventions, NEWS does not duplicate the full git changelog).

@merwok

Copy link
Copy Markdown
Member

Wasn’t there a python.github.io site configured to show docs built from pull requests?

@AlexWaygood

Copy link
Copy Markdown
Member

Wasn’t there a python.github.io site configured to show docs built from pull requests?

The artifact is uploaded here 🙂

@AlexWaygood

AlexWaygood commented Jan 2, 2022

Copy link
Copy Markdown
Member

BTW, @merwok, should this be backported to 3.9? I think distutils was only deprecated in 3.10.

@merwok

Copy link
Copy Markdown
Member

Yes, that’s the artifact, it needs to be downloaded and extracted. I was referring to a website that’s easier to look at 🙂

I checked the 3.9 branch and the _setuptools_disclaimer.rst is there, so we can backport.
The formal deprecation may be in 3.10, but the package was minimally maintained before and setuptools was recommended.

@AlexWaygood

Copy link
Copy Markdown
Member

Yes, that’s the artifact, it needs to be downloaded and extracted. I was referring to a website that’s easier to look at 🙂

I don't know of such a website (but then, I'm fairly new to CPython! If there is one, I'd be very interested to know about it...)

Having downloaded and extracted it myself, this is what it looks like, anyhow!
image

@sobolevn

Copy link
Copy Markdown
MemberAuthor

@AlexWaygood probably @merwok is asking about #30272 and #19025

Right now the automation does not work 😞

@merwokmerwok changed the title bpo-46005: add setuptools note to Doc/extending/building.rstbpo-46005: add note about setuptools to Doc/extending/building.rstJan 2, 2022
@taleinat

Copy link
Copy Markdown
Contributor

Thanks for the PR, @sobolevn!

I'm not sold on this change though. I'm marking this PR as "do not merge" for now, until the discussion on the b.p.o. issue reaches a conclusion.

@AA-Turner

Copy link
Copy Markdown
Member

Trigger CLA

@sobolevn

Copy link
Copy Markdown
MemberAuthor

I am closing this PR, because distutils module was completely removed.
There will be major changes to its documentation.

@sobolevnsobolevn closed this Nov 5, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting mergeDO-NOT-MERGEdocsDocumentation in the Doc dirneeds backport to 3.10only security fixesneeds backport to 3.11only security fixesskip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@sobolevn@merwok@AlexWaygood@taleinat@AA-Turner@serhiy-storchaka@the-knights-who-say-ni@bedevere-bot