Skip to content

bpo-45953: Statically allocate and initialize global bytes objects. - #30096

Merged
ericsnowcurrently merged 7 commits into
python:mainfrom
ericsnowcurrently:global-objects-bytes
Jan 11, 2022
Merged

bpo-45953: Statically allocate and initialize global bytes objects.#30096
ericsnowcurrently merged 7 commits into
python:mainfrom
ericsnowcurrently:global-objects-bytes

Conversation

@ericsnowcurrently

@ericsnowcurrentlyericsnowcurrently commented Dec 14, 2021•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

The empty bytes object (b'') and the 256 one-character bytes objects are allocated at runtime init. Here we statically allocate and initialize them.

https://bugs.python.org/issue45953

@ericsnowcurrentlyericsnowcurrently mentioned this pull request Dec 14, 2021
Closed
markshannon
markshannon reviewed Dec 14, 2021
View reviewed changes
Comment threadInclude/internal/pycore_global_objects.h
markshannon
markshannon reviewed Dec 14, 2021
View reviewed changes
Comment threadInclude/internal/pycore_global_objects.h Outdated
markshannon
markshannon reviewed Jan 10, 2022
View reviewed changes

@markshannonmarkshannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few quibbles, otherwise looks good.

Comment threadInclude/internal/pycore_global_objects.h Outdated
Comment threadInclude/internal/pycore_global_objects.h
.ob_shash = -1, \
.ob_sval[0] = '\0', \
}
#define _PyBytes_CHAR_INIT(CH) \

@markshannonmarkshannonJan 10, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a declaration, not initialization code. Maybe rename to _PyBytes_CHAR?

@ericsnowcurrentlyericsnowcurrentlyJan 10, 2022

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was sticking to the _INIT convention used elsewhere.

Comment threadObjects/bytesobject.c Outdated
Comment threadObjects/bytesobject.c Outdated
@ericsnowcurrently
ericsnowcurrently merged commit cf496d6 into python:mainJan 11, 2022
@ericsnowcurrently
ericsnowcurrently deleted the global-objects-bytes branch January 11, 2022 16:37
@ericsnowcurrentlyericsnowcurrently mentioned this pull request Nov 8, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossumgvanrossumgvanrossum left review comments
@markshannonmarkshannonmarkshannon left review comments

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ericsnowcurrently@gvanrossum@markshannon@the-knights-who-say-ni@bedevere-bot