Uh oh!
There was an error while loading. Please reload this page.
bpo-46119: Update bundled pip to 21.3.1 and setuptools to 59.7.0 - #30178
bpo-46119: Update bundled pip to 21.3.1 and setuptools to 59.7.0#30178kumaraditya303 wants to merge 2 commits into
Conversation
kumaraditya303
commented
Dec 20, 2021
cc @pablogsal |
pablogsal
commented
Dec 20, 2021
Hi @kumaraditya303. Thanks for your PR. Unfortunately I cannot merge this PR directly as I need to Will try to check this as soon as possible if @ambv doesn't do it first :) |
kumaraditya303
commented
Dec 21, 2021
I am thinking about automating this step in cpython with a github action which runs every let's say a week or so and creates a PR with the latest pip and setuptools as manually it takes longer for pip to be updated in the repo and that will be more secure and fast rather than someone doing it. Let me know your thoughts on this @pablogsal |
pablogsal
commented
Dec 21, 2021
That would be a lot of unnecessary churns. We only need to update these pre-release, so technically once a month is ok. On the other hand this can be something done in the release itself. Maybe @ambv has some ideas here |
illia-v
commented
Dec 21, 2021
We can add a unit test that gets hashes of pip and setuptools from Warehouse’s JSON API (e.g., https://pypi.org/pypi/pip/21.3.1/json) and compares it to hashes of the vendored files. |
pablogsal
commented
Dec 21, 2021
Ah, that would certainly be interesting! |
This PR is stale because it has been open for 30 days with no activity. |
MaxwellDupre
left a comment
There was a problem hiding this comment.
Looks straight forward.
hugovk
commented
Feb 7, 2022
Thanks for the review but this is not ready to merge, there are now newer pip and setuptools versions (and possibly a new pip this week). Plus see earlier discussion on how to do this in a way to better fit with the release and avoid churn. |
kumaraditya303
commented
Feb 11, 2022
Closing as this is outdated now. |
illia-v
commented
Mar 14, 2022
Done in #31885 |
https://bugs.python.org/issue46119