Skip to content

bpo-43118: in inspect.signature,use 'base' to help parse 'base.__text_signature__' - #30285

Merged
gvanrossum merged 3 commits into
python:mainfrom
hongweipeng:fix-inspect-signature-fromstr
Jan 21, 2022
Merged

bpo-43118: in inspect.signature,use 'base' to help parse 'base.__text_signature__'#30285
gvanrossum merged 3 commits into
python:mainfrom
hongweipeng:fix-inspect-signature-fromstr

Conversation

@hongweipeng

@hongweipenghongweipeng commented Dec 29, 2021•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

JelleZijlstra
JelleZijlstra reviewed Jan 19, 2022
View reviewed changes
Comment threadMisc/NEWS.d/next/Library/2021-12-29-14-42-09.bpo-43118.BoVi_5.rst Outdated
JelleZijlstra
JelleZijlstra reviewed Jan 19, 2022
View reviewed changes
Comment threadLib/test/test_inspect.py Outdated
JelleZijlstra
JelleZijlstra reviewed Jan 19, 2022
View reviewed changes
Comment threadLib/test/test_inspect.py Outdated
@JelleZijlstra

JelleZijlstra commented Jan 21, 2022

Copy link
Copy Markdown
Member

@gvanrossum I think this is ready to merge.

@JelleZijlstra

JelleZijlstra commented Jan 21, 2022

Copy link
Copy Markdown
Member

Though we need to decide whether this should be backported to 3.9 and 3.10. I'd say yes since it's a bugfix and the old behavior was broken.

@gvanrossum
gvanrossum merged commit 881a763 into python:mainJan 21, 2022
@miss-islington

miss-islington commented Jan 21, 2022

Copy link
Copy Markdown
Contributor

Thanks @hongweipeng for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 21, 2022
@hongweipeng@miss-islington
bpo-43118: Fix bug in inspect.signature around 'base.__text_signature…
e1b3446
…__' (pythonGH-30285)
(cherry picked from commit 881a763)
Co-authored-by: Weipeng Hong <hongweichen8888@sina.com>
@bedevere-botbedevere-bot removed the needs backport to 3.10 only security fixes label Jan 21, 2022
@bedevere-bot

bedevere-bot commented Jan 21, 2022

Copy link
Copy Markdown

GH-30765 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 21, 2022
@hongweipeng@miss-islington
bpo-43118: Fix bug in inspect.signature around 'base.__text_signature…
06e9826
…__' (pythonGH-30285)
(cherry picked from commit 881a763)
Co-authored-by: Weipeng Hong <hongweichen8888@sina.com>
@bedevere-bot

bedevere-bot commented Jan 21, 2022

Copy link
Copy Markdown

GH-30766 is a backport of this pull request to the 3.9 branch.

@gvanrossum

gvanrossum commented Jan 21, 2022

Copy link
Copy Markdown
Member

I hope the commit title I made up covers the change. (If not, too bad -- we don't roll things back to fix commit messages.)

miss-islington added a commit that referenced this pull request Jan 21, 2022
@miss-islington@hongweipeng
bpo-43118: Fix bug in inspect.signature around 'base.__text_signature…
9e3ff82
…__' (GH-30285)
(cherry picked from commit 881a763)
Co-authored-by: Weipeng Hong <hongweichen8888@sina.com>
@hongweipeng
hongweipeng deleted the fix-inspect-signature-fromstr branch January 22, 2022 10:32
@hongweipeng
hongweipeng restored the fix-inspect-signature-fromstr branch January 22, 2022 15:22
gvanrossum pushed a commit that referenced this pull request Jan 22, 2022
@miss-islington@hongweipeng
bpo-43118: Fix bug in inspect.signature around 'base.__text_signature…
83aef4d
…__' (GH-30285) (#30765)
(cherry picked from commit 881a763)
Co-authored-by: Weipeng Hong <hongweichen8888@sina.com>
Co-authored-by: Weipeng Hong <hongweichen8888@sina.com>
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@miss-islington@hongweipeng@hello-adam
bpo-43118: Fix bug in inspect.signature around 'base.__text_signature…
da8553a
…__' (pythonGH-30285)
(cherry picked from commit 881a763)
Co-authored-by: Weipeng Hong <hongweichen8888@sina.com>
@tk0miyatk0miyamannequin mentioned this pull request Sep 9, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstraJelleZijlstraJelleZijlstra approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@hongweipeng@JelleZijlstra@miss-islington@bedevere-bot@gvanrossum@the-knights-who-say-ni