Skip to content

bpo-44136: pathlib: merge _Flavour.is_reserved() into PurePath.is_reserved() - #30321

Closed
barneygale wants to merge 3 commits into
python:mainfrom
barneygale:bpo-44136-merge-is-reserved
Closed

bpo-44136: pathlib: merge _Flavour.is_reserved() into PurePath.is_reserved()#30321
barneygale wants to merge 3 commits into
python:mainfrom
barneygale:bpo-44136-merge-is-reserved

Conversation

@barneygale

@barneygalebarneygale commented Jan 1, 2022•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Removes a bit more indirection.

https://bugs.python.org/issue44136

arhadthedev
arhadthedev reviewed Jan 1, 2022
View reviewed changes
Comment threadLib/pathlib.py Outdated
@barneygale@arhadthedev
Update Lib/pathlib.py
a2baccf
Co-authored-by: Oleg Iarygin <dralife@yandex.ru>
@github-actions

github-actionsBot commented Feb 1, 2022

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actionsgithub-actionsBot added the stale Stale PR or inactive for long period of time. label Feb 1, 2022
@barneygalebarneygale mentioned this pull request Feb 21, 2022
Closed
@brettcannon
brettcannon self-requested a review February 22, 2022 23:33
MaxwellDupre
MaxwellDupre approved these changes Feb 26, 2022
View reviewed changes

@MaxwellDupreMaxwellDupre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me.

@barneygale

barneygale commented Mar 4, 2022

Copy link
Copy Markdown
ContributorAuthor

Closing per the rationale in #30320.

@barneygalebarneygalemannequin mentioned this pull request Jun 21, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arhadthedevarhadthedevarhadthedev left review comments
@brettcannonbrettcannonAwaiting requested review from brettcannon
+1 more reviewer
@MaxwellDupreMaxwellDupreMaxwellDupre approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting core reviewskip newsstaleStale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@barneygale@arhadthedev@MaxwellDupre@brettcannon@the-knights-who-say-ni@bedevere-bot