Skip to content

gh-69093: Add incremental I/O to blobs support in sqlite3 - #30356

Closed
erlend-aasland wants to merge 83 commits into
python:mainfrom
erlend-aasland:sqlite-blob
Closed

gh-69093: Add incremental I/O to blobs support in sqlite3#30356
erlend-aasland wants to merge 83 commits into
python:mainfrom
erlend-aasland:sqlite-blob

Conversation

@erlend-aasland

@erlend-aaslanderlend-aasland commented Jan 3, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

TODO

  • Coverage: Test very large values (offsets > INT_MAX, etc.)
  • Finalise API (open_blob or blobopen?)

https://bugs.python.org/issue24905

palavivand others added 30 commits July 29, 2020 19:37
@palaviv
support BLOB incremental I/O in sqlite module
4fa0e91
@palaviv
Note that blob size cannot be changed using the blob object
3fe9108
@palaviv
Use assertRaises in tests
865c1c8
@palaviv
Fix doc error
788fd54
@palaviv
blob support sequence protocol
a1361e5
@palaviv
Calculate blob length once at creation
5aedfba
@palaviv
Add initial Doc for sequence protocol
db6ef32
@palaviv
Don't support blob operation
219f4cb
@palaviv
move news entry to blurb
6dafe0e
@palaviv
Add blob to PCBuild
ffac901
@palaviv
Update version
3475fa1
@palaviv
Fix memory leak
f6015ff
@palaviv
Update version
01e526c
@palaviv
Fix CR comments in documentation and testing
354bebf
@palaviv
Fix CR comments in code
9709456
@palaviv
Make readonly and dbname keyword arguements only
e6e5099
@palaviv
Fix more CR comments
e9a8080
@palaviv
Add more indicative error on write bigger then blob length
d4fb1b5
Erlend E. Aasland
Merge branch 'main' into sqlite-blob
a7288f9
Erlend E. Aasland
Adapt sqlite3.Connection.open_blob() to AC
525a9c3
Erlend E. Aasland
Adapt sqlite.Blob to AC
2f65cc8
Erlend E. Aasland
PEP 7 and normalised naming
0dd047f
Erlend E. Aasland
Use Py_NewRef and Py_IsNone
d34a77b
Erlend E. Aasland
Harden blob_open()
9d55705
Erlend E. Aasland
Move blob init to blob_open()
d47ea17
Erlend E. Aasland
initialise rc in blob_ass_subscript()
e07a116
Erlend E. Aasland
Improve blob.seek() parameter naming
982c812
Erlend E. Aasland
Adapt to heap types and allow calling close multiple times
e92495b
Erlend E. Aasland
Consolidate tests
8f2ce8a
Erlend E. Aasland
Naming: read_length => length
0a87520
@erlend-aasland

erlend-aasland commented Jan 3, 2022

Copy link
Copy Markdown
ContributorAuthor

Original PR: GH-271
Original author: @palaviv

This PR is based on GH-271, with all changes applied on top of it. Thanks Aviv, for all the good work.

@erlend-aaslanderlend-aasland mentioned this pull request Jan 19, 2022
Merged
@erlend-aaslanderlend-aasland changed the title bpo-24905: Add incremental I/O to blobs support in sqlite3gh-69093: Add incremental I/O to blobs support in sqlite3Apr 10, 2022
@jimminterjimmintermannequin mentioned this pull request Apr 15, 2022
Closed
@JelleZijlstra

JelleZijlstra commented Apr 15, 2022

Copy link
Copy Markdown
Member

@erlend-aasland can this be closed?

@erlend-aasland
erlend-aasland deleted the sqlite-blob branch April 15, 2022 06:07
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner will be requested when the pull request is marked ready for reviewAA-Turner is a code owner

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@erlend-aasland@JelleZijlstra@the-knights-who-say-ni@bedevere-bot@palaviv