Skip to content

bpo-46236: Fix PyFunction_GetAnnotations() returned tuple. - #30409

Merged
miss-islington merged 4 commits into
python:mainfrom
methane:fix-46236
Jan 5, 2022
Merged

bpo-46236: Fix PyFunction_GetAnnotations() returned tuple.#30409
miss-islington merged 4 commits into
python:mainfrom
methane:fix-46236

Conversation

@methane

@methanemethane commented Jan 5, 2022•
edited by miss-islington
Loading

Copy link
Copy Markdown
Member

https://bugs.python.org/issue46236

Automerge-Triggered-By: GH:pablogsal

@methanemethane added needs backport to 3.10 only security fixes type-bug An unexpected behavior, bug, or error labels Jan 5, 2022
sweeneyde
sweeneyde reviewed Jan 5, 2022
View reviewed changes
Comment threadObjects/funcobject.c
kumaraditya303
kumaraditya303 reviewed Jan 5, 2022
View reviewed changes
Comment threadObjects/funcobject.c
pablogsal
pablogsal reviewed Jan 5, 2022
View reviewed changes
Comment threadMisc/NEWS.d/next/C API/2022-01-05-10-16-16.bpo-46236.pcmVQw.rst Outdated
pablogsal
pablogsal approved these changes Jan 5, 2022
View reviewed changes

@pablogsalpablogsal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks a lot for the quick fix, @methane!

@miss-islington

miss-islington commented Jan 5, 2022

Copy link
Copy Markdown
Contributor

@methane: Status check is done, and it's a success ✅ .

@miss-islington
miss-islington merged commit 46e4c25 into python:mainJan 5, 2022
@miss-islington

miss-islington commented Jan 5, 2022

Copy link
Copy Markdown
Contributor

Thanks @methane for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 5, 2022
@methane@miss-islington
bpo-46236: Fix PyFunction_GetAnnotations() returned tuple. (pythonGH-…
4a3b386
…30409)
Automerge-Triggered-By: GH:pablogsal
(cherry picked from commit 46e4c25)
Co-authored-by: Inada Naoki <songofacandy@gmail.com>
@bedevere-botbedevere-bot removed the needs backport to 3.10 only security fixes label Jan 5, 2022
@bedevere-bot

bedevere-bot commented Jan 5, 2022

Copy link
Copy Markdown

GH-30420 is a backport of this pull request to the 3.10 branch.

miss-islington added a commit that referenced this pull request Jan 5, 2022
@miss-islington@methane
bpo-46236: Fix PyFunction_GetAnnotations() returned tuple. (GH-30409)
da8be15
Automerge-Triggered-By: GH:pablogsal
(cherry picked from commit 46e4c25)
Co-authored-by: Inada Naoki <songofacandy@gmail.com>
@larryhastingslarryhastings mentioned this pull request Oct 5, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sweeneydesweeneydesweeneyde left review comments
@kumaraditya303kumaraditya303kumaraditya303 left review comments
@pablogsalpablogsalpablogsal approved these changes

Assignees

No one assigned

Labels

type-bugAn unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@methane@miss-islington@bedevere-bot@pablogsal@sweeneyde@kumaraditya303@the-knights-who-say-ni