Uh oh!
There was an error while loading. Please reload this page.
[3.10] bpo-46006: Revert "bpo-40521: Per-interpreter interned strings (GH-20085)" (GH-30422) - #30433
Closed
vstinner wants to merge 1 commit into
Closed
[3.10] bpo-46006: Revert "bpo-40521: Per-interpreter interned strings (GH-20085)" (GH-30422)#30433vstinner wants to merge 1 commit into
vstinner wants to merge 1 commit into
Conversation
)" (GH-30422) This reverts commit ea25180. Keep "assert(interned == NULL);" in _PyUnicode_Fini(), but only for the main interpreter. Keep _PyUnicode_ClearInterned() changes avoiding the creation of a temporary Python list object. Leave PyInterpreterState structure unchanged to keep the ABI backward compatibility with Python 3.10.0: just rename "interned" to "unused_interned". (cherry picked from commit 35d6540)
vstinner
commented
Jan 6, 2022
MemberAuthor
I cannot merge #30425 because of an "unresolved conversation", but I can no longer access the conversation, since it's gone after a |
vstinner
commented
Jan 6, 2022
MemberAuthor
I merged #30425 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit ea25180.
Keep "assert(interned == NULL);" in _PyUnicode_Fini(), but only for
the main interpreter.
Keep _PyUnicode_ClearInterned() changes avoiding the creation of a
temporary Python list object.
Leave PyInterpreterState structure unchanged to keep the ABI backward
compatibility with Python 3.10.0: just rename "interned" to
"unused_interned".
(cherry picked from commit 35d6540)
https://bugs.python.org/issue46006