Uh oh!
There was an error while loading. Please reload this page.
bpo-40280: Add --with-emscripten-target to build for browser or node (GH-30552) - #30552
Merged
Conversation
Co-authored-by: Ethan Smith <ethan@ethanhs.me> Signed-off-by: Christian Heimes <christian@python.org>
tiranforce-pushed
the
bpo-40280-emscripten-targets
branch
from
January 11, 2022 23:46
a1aab67 to
b5b4504CompareUh oh!
There was an error while loading. Please reload this page.
brettcannon
self-requested a review
January 12, 2022 01:08
Uh oh!
There was an error while loading. Please reload this page.
emmatyping
approved these changes
Jan 12, 2022
emmatyping
left a comment
Member
There was a problem hiding this comment.
Two suggestions but otherwise this looks good! It is a bit unfortunate that running emmake make after the correct configure doesn't "just work" but alas.
tiran
commented
Jan 12, 2022
MemberAuthor
It does now :) |
tiran
marked this pull request as ready for review
January 12, 2022 09:01
This was referenced Jan 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Ethan Smith ethan@ethanhs.me
Signed-off-by: Christian Heimes christian@python.org
https://bugs.python.org/issue40280