Skip to content

[3.10] bpo-46070: Revert "bpo-36854: Move _PyRuntimeState.gc to PyInterpreterState (GH-17287)" - #30565

Closed
vstinner wants to merge 2 commits into
python:3.10from
vstinner:revert_gc310
Closed

[3.10] bpo-46070: Revert "bpo-36854: Move _PyRuntimeState.gc to PyInterpreterState (GH-17287)"#30565
vstinner wants to merge 2 commits into
python:3.10from
vstinner:revert_gc310

Conversation

@vstinner

@vstinnervstinner commented Jan 12, 2022•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

This reverts commit 7247407.

Fix a random crash involving subinterpreters on Windows. Revert the
change which made the gc module state per interpreter: the gc module
state is shared again by all interpreters.

https://bugs.python.org/issue36854

@vstinner
vstinner marked this pull request as draft January 12, 2022 23:23
@vstinner
bpo-46070: Revert "bpo-36854: Move _PyRuntimeState.gc to PyInterprete…
64ce003
…rState (GH-17287)"
This reverts commit 7247407.
Fix a random crash involving subinterpreters on Windows. Revert the
change which made the gc module state per interpreter: the gc module
state is shared again by all interpreters.
@vstinnervstinner changed the title [3.10] Revert "bpo-36854: Move _PyRuntimeState.gc to PyInterpreterState (GH-17287)"bpo-46070: [3.10] Revert "bpo-36854: Move _PyRuntimeState.gc to PyInterpreterState (GH-17287)"Jan 12, 2022
ericsnowcurrently
ericsnowcurrently approved these changes Jan 12, 2022
View reviewed changes

@ericsnowcurrentlyericsnowcurrently left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinnervstinner changed the title bpo-46070: [3.10] Revert "bpo-36854: Move _PyRuntimeState.gc to PyInterpreterState (GH-17287)"[3.10] bpo-46070: Revert "bpo-36854: Move _PyRuntimeState.gc to PyInterpreterState (GH-17287)"Jan 13, 2022
@vstinner

vstinner commented Jan 13, 2022

Copy link
Copy Markdown
MemberAuthor

I wrote a simpler fix: GH-30577.

@vstinner
vstinner deleted the revert_gc310 branch January 13, 2022 18:31
@grayskygrayskymannequin mentioned this pull request Apr 10, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrentlyericsnowcurrentlyericsnowcurrently approved these changes
@pablogsalpablogsalAwaiting requested review from pablogsalpablogsal is a code owner

Assignees

No one assigned

Labels

awaiting merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vstinner@ericsnowcurrently@the-knights-who-say-ni@bedevere-bot