Skip to content

bpo-40280: Skip subprocess-based tests on wasm32-emscripten (GH-30615) - #30615

Merged
tiran merged 1 commit into
python:mainfrom
tiran:bpo-40280-test-subprocess
Jan 25, 2022
Merged

bpo-40280: Skip subprocess-based tests on wasm32-emscripten (GH-30615)#30615
tiran merged 1 commit into
python:mainfrom
tiran:bpo-40280-test-subprocess

Conversation

@tiran

@tirantiran commented Jan 15, 2022•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

kumaraditya303
kumaraditya303 reviewed Jan 15, 2022
View reviewed changes
Comment threadMisc/NEWS.d/next/Tests/2022-01-14-23-22-41.bpo-40280.nHLWoD.rst Outdated
@tiran
tiranforce-pushed the bpo-40280-test-subprocess branch from e61311a to 87fd2feCompareJanuary 16, 2022 22:03
emmatyping
emmatyping reviewed Jan 17, 2022
View reviewed changes
Comment threadLib/test/support/__init__.py Outdated
@tiran
tiranforce-pushed the bpo-40280-test-subprocess branch 2 times, most recently from 61decef to 8c9097eCompareJanuary 21, 2022 15:38
@tiran
tiranforce-pushed the bpo-40280-test-subprocess branch from 8c9097e to d20fdb2CompareJanuary 24, 2022 08:19
@tiran
tiran marked this pull request as ready for review January 24, 2022 08:52
gpshead
gpshead reviewed Jan 24, 2022
View reviewed changes
Comment threadLib/lib2to3/tests/test_parser.py
Comment threadLib/test/support/__init__.py
emmatyping
emmatyping approved these changes Jan 25, 2022
View reviewed changes

@emmatypingemmatyping left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

@tirantiran changed the title bpo-40280: Skip subprocess-based tests on wasm32-emscriptenbpo-40280: Skip subprocess-based tests on wasm32-emscripten (GH-30615)Jan 25, 2022
@tiran
tiran merged commit 8464fbc into python:mainJan 25, 2022
@tiran
tiran deleted the bpo-40280-test-subprocess branch January 25, 2022 07:09
@SimonBiggsSimonBiggsmannequin mentioned this pull request Jun 7, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303kumaraditya303kumaraditya303 left review comments
@gpsheadgpsheadgpshead approved these changes
@emmatypingemmatypingemmatyping approved these changes
@iritkatrieliritkatrielAwaiting requested review from iritkatriel
@vsajipvsajipAwaiting requested review from vsajipvsajip is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tiran@gpshead@emmatyping@kumaraditya303@the-knights-who-say-ni@bedevere-bot