Skip to content

bpo-46424: cover Annotation[int] invalid usage in tests - #30663

Merged
Fidget-Spinner merged 1 commit into
python:mainfrom
sobolevn:issue-46424
Jan 18, 2022
Merged

bpo-46424: cover Annotation[int] invalid usage in tests#30663
Fidget-Spinner merged 1 commit into
python:mainfrom
sobolevn:issue-46424

Conversation

@sobolevn

@sobolevnsobolevn commented Jan 18, 2022•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@bedevere-botbedevere-bot added tests Tests in the Lib/test dir awaiting review labels Jan 18, 2022
@Fidget-Spinner
Fidget-Spinner merged commit 3239829 into python:mainJan 18, 2022
@Fidget-Spinner

Fidget-Spinner commented Jan 19, 2022

Copy link
Copy Markdown
Member

@sobolevn could you do me a favour please and mark any of your typing tests PRs as needs backport to x.x? I will review and merge them for you. My motivation follows:

  • Easier to handle future bugfix backports.
  • Properly test older versions of Python, so that bugfix backports don't accidentally break things.

Thanks for your time!

@miss-islington

miss-islington commented Jan 19, 2022

Copy link
Copy Markdown
Contributor

Thanks @sobolevn for the PR, and @Fidget-Spinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Jan 19, 2022

Copy link
Copy Markdown
Contributor

Thanks @sobolevn for the PR, and @Fidget-Spinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington

miss-islington commented Jan 19, 2022

Copy link
Copy Markdown
Contributor

Sorry @sobolevn and @Fidget-Spinner, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 32398294fb3fcf4ee74da54722fd0221c4e6cb74 3.9

@bedevere-botbedevere-bot removed the needs backport to 3.10 only security fixes label Jan 19, 2022
@bedevere-bot

bedevere-bot commented Jan 19, 2022

Copy link
Copy Markdown

GH-30691 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 19, 2022
@sobolevn@miss-islington
bpo-46424: [typing] coverAnnotation[arg]invalid usage in tests (p…
4b8b369
…ythonGH-30663)
(cherry picked from commit 3239829)
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@miss-islington

miss-islington commented Jan 19, 2022

Copy link
Copy Markdown
Contributor

Thanks @sobolevn for the PR, and @Fidget-Spinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Jan 19, 2022

Copy link
Copy Markdown

GH-30692 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 19, 2022
@sobolevn@miss-islington
bpo-46424: [typing] coverAnnotation[arg]invalid usage in tests (p…
30b0b05
…ythonGH-30663)
(cherry picked from commit 3239829)
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington added a commit that referenced this pull request Jan 19, 2022
@miss-islington@sobolevn
bpo-46424: [typing] coverAnnotation[arg]invalid usage in tests (G…
baf26d0
…H-30663)
(cherry picked from commit 3239829)
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington added a commit that referenced this pull request Jan 19, 2022
@miss-islington@sobolevn
[3.9]bpo-46424: [typing] coverAnnotation[arg]invalid usage in te…
331378d
…sts (GH-30663) (GH-30692)
(cherry picked from commit 3239829)
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@sobolevn

sobolevn commented Jan 19, 2022

Copy link
Copy Markdown
MemberAuthor

@Fidget-Spinner sure thing, will do in the future!

hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@miss-islington@sobolevn@hello-adam
[3.9] bpo-46424: [typing] cover Annotation[arg] invalid usage in te…
242946e
…sts (pythonGH-30663) (pythonGH-30692)
(cherry picked from commit 3239829)
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovkhugovkhugovk approved these changes
@Fidget-SpinnerFidget-SpinnerFidget-Spinner approved these changes
@gvanrossumgvanrossumAwaiting requested review from gvanrossum

Assignees

@Fidget-SpinnerFidget-Spinner

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@sobolevn@Fidget-Spinner@miss-islington@bedevere-bot@hugovk@the-knights-who-say-ni