Skip to content

bpo-46425: fix direct invocation of test_sqlite3 - #30676

Merged
asvetlov merged 1 commit into
python:mainfrom
sobolevn:issue-46425-2
Jan 22, 2022
Merged

bpo-46425: fix direct invocation of test_sqlite3#30676
asvetlov merged 1 commit into
python:mainfrom
sobolevn:issue-46425-2

Conversation

@sobolevn

@sobolevnsobolevn commented Jan 18, 2022

Copy link
Copy Markdown
Member

This fixes ./python.exe Lib/test/test_sqlite3/... tests.
Without this change it fails:

» ./python.exe Lib/test/test_sqlite3/test_transactions.py Traceback (most recent call last):
File "/Users/sobolev/Desktop/cpython/Lib/test/test_sqlite3/test_transactions.py", line 26, in <module>
from .test_dbapi import memory_database
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ImportError: attempted relative import with no known parent package

Refs #30666
CC @corona10 as my mentor.

https://bugs.python.org/issue46425

@bedevere-botbedevere-bot added tests Tests in the Lib/test dir awaiting review labels Jan 18, 2022
@zwarezware changed the title bpo-46425: fix direct invokation of test_sqlite3bpo-46425: fix direct invocation of test_sqlite3Jan 18, 2022

@erlend-aaslanderlend-aasland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@erlend-aasland

erlend-aasland commented Jan 18, 2022

Copy link
Copy Markdown
Contributor

This should not be backported. The sqlite3 test suite has changed a lot since 3.10 and 3.9. I don't think this would apply cleanly at all. IMO, I don't think it is worth backporting it.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@sobolevn@erlend-aasland@asvetlov@JelleZijlstra@kumaraditya303@the-knights-who-say-ni@bedevere-bot