Uh oh!
There was an error while loading. Please reload this page.
bpo-46417: Py_Finalize() clears static types - #30743
Merged
Merged
Conversation
Add _PyTypes_FiniTypes(): best-effort function to clear static types, don't deallocate a type if it still has subclasses. remove_subclass() now sets tp_subclasses to NULL when removing the last subclass.
vstinner
commented
Jan 21, 2022
MemberAuthor
Using PR #30744, the effect of this PR is quite clear on the total reference count after Py_Finalize():
This PR removes 5319 references. With the PR, there are 2.1x less references leaked after Py_Finalize()! |
vstinner
commented
Jan 21, 2022
MemberAuthor
_PyTypes_FiniTypes() is tested (indirectly) by multiple test_embed tests which use many of the cleared types after Py_Finalize(). |
bedevere-bot
commented
Jan 21, 2022
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add _PyTypes_FiniTypes(): best-effort function to clear static types,
don't deallocate a type if it still has subclasses.
remove_subclass() now sets tp_subclasses to NULL when removing the
last subclass.
https://bugs.python.org/issue46417