Skip to content

bpo-46469: Make asyncio generic classes return GenericAlias - #30777

Merged
asvetlov merged 3 commits into
python:mainfrom
kumaraditya303:issue46469
Jan 22, 2022
Merged

bpo-46469: Make asyncio generic classes return GenericAlias#30777
asvetlov merged 3 commits into
python:mainfrom
kumaraditya303:issue46469

Conversation

@kumaraditya303

@kumaraditya303kumaraditya303 commented Jan 22, 2022•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

JelleZijlstra
JelleZijlstra reviewed Jan 22, 2022
View reviewed changes
Comment threadMisc/NEWS.d/next/Library/2022-01-22-05-05-08.bpo-46469.plUab5.rst Outdated
@JelleZijlstra

JelleZijlstra commented Jan 22, 2022

Copy link
Copy Markdown
Member

These methods have existed since 3.9, but apparently aren't documented. Should the fix be backported?

sobolevn
sobolevn reviewed Jan 22, 2022
View reviewed changes

@sobolevnsobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should probably also add these types to

cpython/Lib/test/test_genericalias.py

Line 52 in 82c5322

generic_types= [type, tuple, list, dict, set, frozenset, enumerate,

@kumaraditya303

kumaraditya303 commented Jan 22, 2022

Copy link
Copy Markdown
ContributorAuthor

These methods have existed since 3.9, but apparently aren't documented. Should the fix be backported?

This should be backported.

@kumaraditya303@JelleZijlstra
Update Misc/NEWS.d/next/Library/2022-01-22-05-05-08.bpo-46469.plUab5.rst
fee6d09
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@kumaraditya303

kumaraditya303 commented Jan 22, 2022

Copy link
Copy Markdown
ContributorAuthor

You should probably also add these types to

cpython/Lib/test/test_genericalias.py

Line 52 in 82c5322

generic_types= [type, tuple, list, dict, set, frozenset, enumerate,

There isn't any need to test it more than once and in the asyncio it tests both the c and python implementation so no need.

@asvetlov
asvetlov merged commit ea5b968 into python:mainJan 22, 2022
@miss-islington

miss-islington commented Jan 22, 2022

Copy link
Copy Markdown
Contributor

Thanks @kumaraditya303 for the PR, and @asvetlov for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@kumaraditya303
kumaraditya303 deleted the issue46469 branch January 22, 2022 11:29
@miss-islington

miss-islington commented Jan 22, 2022

Copy link
Copy Markdown
Contributor

Sorry, @kumaraditya303 and @asvetlov, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker ea5b96842e066623a53015d8b2492ed61a5baf96 3.9

@bedevere-bot

bedevere-bot commented Jan 22, 2022

Copy link
Copy Markdown

GH-30784 is a backport of this pull request to the 3.10 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.10 only security fixes label Jan 22, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 22, 2022
@kumaraditya303@miss-islington
bpo-46469: Make asyncio generic classes return GenericAlias (pythonGH…
52fd95e
…-30777)
* bpo-46469: Make asyncio generic classes return GenericAlias
* 📜🤖 Added by blurb_it.
* Update Misc/NEWS.d/next/Library/2022-01-22-05-05-08.bpo-46469.plUab5.rst
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit ea5b968)
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
@asvetlov

asvetlov commented Jan 22, 2022

Copy link
Copy Markdown
Contributor

Thanks. I'm constantly forgetting to make this change.

@bedevere-bot

bedevere-bot commented Jan 22, 2022

Copy link
Copy Markdown

GH-30785 is a backport of this pull request to the 3.9 branch.

kumaraditya303 added a commit to kumaraditya303/cpython that referenced this pull request Jan 22, 2022
@kumaraditya303
bpo-46469: Make asyncio generic classes return GenericAlias (pythonGH…
5adf7fe
…-30777)
asvetlov added a commit that referenced this pull request Jan 22, 2022
@miss-islington@kumaraditya303@asvetlov
[3.10]bpo-46469: Make asyncio generic classes return GenericAlias (G…
90e2998
…H-30777) (#30784)
* bpo-46469: Make asyncio generic classes return GenericAlias (GH-30777)
* bpo-46469: Make asyncio generic classes return GenericAlias
* 📜🤖 Added by blurb_it.
* Update Misc/NEWS.d/next/Library/2022-01-22-05-05-08.bpo-46469.plUab5.rst
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit ea5b968)
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
* Fix tests
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
miss-islington pushed a commit that referenced this pull request Jan 22, 2022
@kumaraditya303
[3.9]bpo-46469: Make asyncio generic classes return GenericAlias (GH…
6ed874f
…-30777) (GH-30785)
Automerge-Triggered-By: GH:asvetlov
@sobolevnsobolevn mentioned this pull request Jan 23, 2022
Merged
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@kumaraditya303@hello-adam
[3.9] bpo-46469: Make asyncio generic classes return GenericAlias (py…
6a87c42
…thonGH-30777) (pythonGH-30785)
Automerge-Triggered-By: GH:asvetlov
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstraJelleZijlstraJelleZijlstra left review comments
@sobolevnsobolevnsobolevn left review comments
@asvetlovasvetlovasvetlov approved these changes
@1st11st1Awaiting requested review from 1st11st1 is a code owner
@rhettingerrhettingerAwaiting requested review from rhettinger

Assignees

@asvetlovasvetlov

Labels

topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@kumaraditya303@JelleZijlstra@miss-islington@bedevere-bot@asvetlov@sobolevn@the-knights-who-say-ni