Uh oh!
There was an error while loading. Please reload this page.
bpo-46491: Allow Annotated on outside of Final/ClassVar - #30864
Merged
Conversation
This exempts it from checks against Final and ClassVar in order to allow using them in any nesting order.
GBeauregard
requested review from
Fidget-Spinner and gvanrossum
as code ownersJanuary 24, 2022 23:53
JelleZijlstra
requested changes
Jan 25, 2022
JelleZijlstra
left a comment
Member
There was a problem hiding this comment.
Thanks for your contribution! A few comments.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
gvanrossum
commented
Jan 25, 2022
Member
Please add me back once this is ready to merge. |
Uh oh!
There was an error while loading. Please reload this page.
JelleZijlstra
approved these changes
Jan 25, 2022
JelleZijlstra
left a comment
Member
There was a problem hiding this comment.
@gvanrossum I think this is ready now.
gvanrossum
approved these changes
Jan 25, 2022
gvanrossum
commented
Jan 25, 2022
Member
Maybe this should be backported? |
JelleZijlstra
commented
Jan 25, 2022
Member
Agree, I added the labels |
miss-islington
commented
Jan 25, 2022
Contributor
@GBeauregard: Status check is done, and it's a success ✅ . |
miss-islington
commented
Jan 25, 2022
Contributor
Thanks @GBeauregard for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
bedevere-bot
commented
Jan 25, 2022
GH-30873 is a backport of this pull request to the 3.10 branch. |
miss-islington pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 25, 2022
We treat Annotated type arg as class-level annotation. This exempts it from checks against Final and ClassVar in order to allow using them in any nesting order. Automerge-Triggered-By: GH:gvanrossum (cherry picked from commit e1abffc) Co-authored-by: Gregory Beauregard <greg@greg.red>
miss-islington pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 25, 2022
We treat Annotated type arg as class-level annotation. This exempts it from checks against Final and ClassVar in order to allow using them in any nesting order. Automerge-Triggered-By: GH:gvanrossum (cherry picked from commit e1abffc) Co-authored-by: Gregory Beauregard <greg@greg.red>
bedevere-bot
commented
Jan 25, 2022
GH-30874 is a backport of this pull request to the 3.9 branch. |
miss-islington added a commit
that referenced
this pull request
Jan 25, 2022
We treat Annotated type arg as class-level annotation. This exempts it from checks against Final and ClassVar in order to allow using them in any nesting order. Automerge-Triggered-By: GH:gvanrossum (cherry picked from commit e1abffc) Co-authored-by: Gregory Beauregard <greg@greg.red>
miss-islington added a commit
that referenced
this pull request
Jan 25, 2022
We treat Annotated type arg as class-level annotation. This exempts it from checks against Final and ClassVar in order to allow using them in any nesting order. Automerge-Triggered-By: GH:gvanrossum (cherry picked from commit e1abffc) Co-authored-by: Gregory Beauregard <greg@greg.red>
hello-adam pushed a commit
to hello-adam/cpython
that referenced
this pull request
Jun 2, 2022
We treat Annotated type arg as class-level annotation. This exempts it from checks against Final and ClassVar in order to allow using them in any nesting order. Automerge-Triggered-By: GH:gvanrossum (cherry picked from commit e1abffc) Co-authored-by: Gregory Beauregard <greg@greg.red>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We treat Annotated type arg as class-level annotation. This exempts it from checks against Final and ClassVar in order to allow using them in any nesting order.
https://bugs.python.org/issue46491
Automerge-Triggered-By: GH:gvanrossum