Skip to content

bpo-40280: Address more test failures on Emscripten (GH-31050) - #31050

Merged
tiran merged 9 commits into
python:mainfrom
tiran:bpo-40280-more-test-fixes
Feb 5, 2022
Merged

bpo-40280: Address more test failures on Emscripten (GH-31050)#31050
tiran merged 9 commits into
python:mainfrom
tiran:bpo-40280-more-test-fixes

Conversation

@tiran

@tirantiran commented Feb 1, 2022•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Fix wasm32-emscripten test failures and platform issues.

  • Disable syscalls that are not supported or don't work, e.g.
    wait, getrusage, prlimit, mkfifo, mknod, setres[gu]id, setgroups.
  • Use fd_count to cound open fds.
  • Add more checks for subprocess and fork.
  • Add workarounds for missing _multiprocessing and failing socket.accept()
  • Enable bzip2 again
  • Disable large file support
  • Disable signal.alarm for now

https://bugs.python.org/issue40280

@tiran
tiran marked this pull request as ready for review February 1, 2022 14:14
@tiran
tiranforce-pushed the bpo-40280-more-test-fixes branch from e9d6e24 to b34c808CompareFebruary 1, 2022 16:02
@brettcannon
brettcannon self-requested a review February 1, 2022 19:17
brettcannon
brettcannon approved these changes Feb 4, 2022
View reviewed changes

@brettcannonbrettcannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the comments are about recording the known bugs in emscripten and musl so we can easily track when they are fixed.

Comment threadLib/test/support/__init__.py Outdated
Comment threadLib/test/test_os.py Outdated
Comment threadLib/test/test_pwd.py Outdated
Comment threadMisc/NEWS.d/next/Build/2022-01-31-15-15-08.bpo-40280.r1AYNW.rst Outdated
Comment threadTools/wasm/README.md Outdated
Comment threadTools/wasm/README.md Outdated

@brettcannonbrettcannonFeb 4, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link to the bugs?

Comment threadTools/wasm/README.md Outdated

@brettcannonbrettcannonFeb 4, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link to the bug?

@tirantiranFeb 5, 2022

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added links to bpo and emscripten bug tracker.

Comment threadTools/wasm/README.md Outdated
Comment threadTools/wasm/README.md Outdated
Comment threadTools/wasm/README.md Outdated
@tiran
tiranforce-pushed the bpo-40280-more-test-fixes branch from c00edf3 to 5f29e63CompareFebruary 5, 2022 16:32
@tiran

tiran commented Feb 5, 2022

Copy link
Copy Markdown
MemberAuthor

Thanks for the review!

@tiran

tiran commented Feb 5, 2022

Copy link
Copy Markdown
MemberAuthor

The failing Windows test is covered by GH-31146

@tirantiran changed the title bpo-40280: Address more test failures on Emscriptenbpo-40280: Address more test failures on Emscripten (GH-31050)Feb 5, 2022
@tiran
tiran merged commit 96b344c into python:mainFeb 5, 2022
@tiran
tiran deleted the bpo-40280-more-test-fixes branch February 5, 2022 19:52
@SimonBiggsSimonBiggsmannequin mentioned this pull request Jun 7, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannonbrettcannonbrettcannon approved these changes
@abalkinabalkinAwaiting requested review from abalkin
@pgansslepganssleAwaiting requested review from pgansslepganssle is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tiran@brettcannon@the-knights-who-say-ni@bedevere-bot