Skip to content

bpo-46541: Remove usage of _Py_IDENTIFIER from dbms modules - #31358

Merged
corona10 merged 3 commits into
python:mainfrom
corona10:bpo-46541-dbms
Feb 16, 2022
Merged

bpo-46541: Remove usage of _Py_IDENTIFIER from dbms modules#31358
corona10 merged 3 commits into
python:mainfrom
corona10:bpo-46541-dbms

Conversation

@corona10

@corona10corona10 commented Feb 15, 2022•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

erlend-aasland
erlend-aasland reviewed Feb 15, 2022
View reviewed changes
Comment threadModules/_gdbmmodule.c Outdated
@erlend-aasland

erlend-aasland commented Feb 15, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

You need to regenerate global objects. Either run Tools/scripts/generate_global_objects.py, or do make regen-global-objects (I prefer the former as I build out of tree).

Sorry, close is already there :)

erlend-aasland
erlend-aasland approved these changes Feb 15, 2022
View reviewed changes

@erlend-aaslanderlend-aasland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, as far as I can see. Let's wait and hear what Eric says.

@ericsnowcurrently

ericsnowcurrently commented Feb 15, 2022

Copy link
Copy Markdown
Member

I have reservations. See #31351 (comment).

@ericsnowcurrently

ericsnowcurrently commented Feb 15, 2022

Copy link
Copy Markdown
Member

Also, thanks for working on this! 🙂

@corona10corona10 changed the title bpo-46541: Replace _Py_IDENTIFIER with _Py_ID in dbms modulesbpo-46541: Remove usage of _Py_IDENTIFIER from dbms modulesFeb 16, 2022
@corona10
corona10force-pushed the bpo-46541-dbms branch 2 times, most recently from d450463 to dc57f78CompareFebruary 16, 2022 02:29
@corona10

corona10 commented Feb 16, 2022

Copy link
Copy Markdown
MemberAuthor

@ericsnowcurrently@ericsnowcurrently
PTAL :)

erlend-aasland
erlend-aasland reviewed Feb 16, 2022
View reviewed changes
Comment threadModules/_dbmmodule.c Outdated
erlend-aasland
erlend-aasland approved these changes Feb 16, 2022
View reviewed changes

@erlend-aaslanderlend-aasland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@corona10
corona10 merged commit e59309b into python:mainFeb 16, 2022
@corona10
corona10 deleted the bpo-46541-dbms branch February 16, 2022 09:57
@ericsnowcurrentlyericsnowcurrently mentioned this pull request Jul 9, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes
@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrently

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@corona10@erlend-aasland@ericsnowcurrently@the-knights-who-say-ni@bedevere-bot