Skip to content

bpo-46066: catch DeprecationWarning - #31428

Merged
JelleZijlstra merged 2 commits into
python:mainfrom
JelleZijlstra:tddepr
Feb 20, 2022
Merged

bpo-46066: catch DeprecationWarning#31428
JelleZijlstra merged 2 commits into
python:mainfrom
JelleZijlstra:tddepr

Conversation

@JelleZijlstra

@JelleZijlstraJelleZijlstra commented Feb 19, 2022•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@bedevere-botbedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Feb 19, 2022
sobolevn
sobolevn reviewed Feb 19, 2022
View reviewed changes
Comment threadLib/test/test_typing.py Outdated
97littleleaf11
97littleleaf11 reviewed Feb 19, 2022
View reviewed changes

@97littleleaf1197littleleaf11 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, sorry that I missed the warnings. Thanks @tirkarthi for pointing out!

Comment threadLib/test/test_typing.py Outdated
JelleZijlstra
JelleZijlstra commented Feb 19, 2022
View reviewed changes
Comment threadLib/test/test_typing.py Outdated
sobolevn
sobolevn approved these changes Feb 19, 2022
View reviewed changes

@sobolevnsobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@JelleZijlstra

JelleZijlstra commented Feb 19, 2022

Copy link
Copy Markdown
MemberAuthor

@gvanrossum Planning to merge this simple PR (fixes an oversight in the TD kwargs deprecation change; approved by Nikita).

gvanrossum
gvanrossum approved these changes Feb 19, 2022
View reviewed changes

@gvanrossumgvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’d rephrase the commit message using “Check deprecation warning”.

@AlexWaygoodAlexWaygood mentioned this pull request Feb 19, 2022
Closed
@JelleZijlstra
JelleZijlstra merged commit 0a8a8e7 into python:mainFeb 20, 2022
@JelleZijlstra
JelleZijlstra deleted the tddepr branch February 20, 2022 01:44
@97littleleaf1197littleleaf11mannequin mentioned this pull request Dec 22, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossumgvanrossumgvanrossum approved these changes
@sobolevnsobolevnsobolevn approved these changes
@Fidget-SpinnerFidget-SpinnerAwaiting requested review from Fidget-Spinner
+1 more reviewer
@97littleleaf1197littleleaf1197littleleaf11 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@JelleZijlstra@gvanrossum@sobolevn@97littleleaf11@the-knights-who-say-ni@bedevere-bot