Skip to content

bpo-46586: Fix more erroneous doc links to builtins - #31429

Merged
JelleZijlstra merged 8 commits into
python:mainfrom
meersuri:fix-issue-46586
May 2, 2022
Merged

bpo-46586: Fix more erroneous doc links to builtins#31429
JelleZijlstra merged 8 commits into
python:mainfrom
meersuri:fix-issue-46586

Conversation

@meersuri

@meersurimeersuri commented Feb 19, 2022•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-botbedevere-bot added the docs Documentation in the Doc dir label Feb 19, 2022
@AlexWaygood

AlexWaygood commented Feb 19, 2022

Copy link
Copy Markdown
Member

Hi, it looks like you need to merge origin/main into your branch here — the enum.property fix is still showing up in this PR, even though that one's already been committed to main 🙂

merwok
merwok reviewed Mar 5, 2022
View reviewed changes
Comment threadDoc/library/io.rst Outdated
merwok
merwok reviewed Mar 5, 2022
View reviewed changes
Comment threadDoc/library/zipfile.rst Outdated
JelleZijlstra
JelleZijlstra reviewed May 2, 2022
View reviewed changes
Comment threadDoc/library/io.rst Outdated
@JelleZijlstra@merwok
Apply suggestions from code review
ccf9af7
Co-authored-by: Éric <merwok@netwok.org>
@JelleZijlstraJelleZijlstra self-assigned this May 2, 2022
merwok
merwok reviewed May 2, 2022
View reviewed changes
Comment threadDoc/library/fileinput.rst Outdated
merwok
merwok reviewed May 2, 2022
View reviewed changes
Comment threadDoc/library/urllib.request.rst Outdated
@JelleZijlstra@merwok
Apply suggestions from code review
5d0aad4
Co-authored-by: Éric <merwok@netwok.org>
@merwok

merwok commented May 2, 2022•
edited
Loading

Copy link
Copy Markdown
Member

Thanks for this PR!
Could we also fix the wrong markup in the documentation of structseq objects? (see #90744 (comment))

@JelleZijlstra

JelleZijlstra commented May 2, 2022

Copy link
Copy Markdown
Member

@merwok let's keep that for another PR, so we can land this one.

@merwok

merwok commented May 2, 2022

Copy link
Copy Markdown
Member

I don’t really get why split these fixes into three changes here, two changes there (and the original ticket about enum has already had its scope widered), but 🤷🏽 it’s up to you! Better to merge some fixes than none 🙂

@JelleZijlstra
JelleZijlstra merged commit cc6ae4f into python:mainMay 2, 2022
@miss-islington

miss-islington commented May 2, 2022

Copy link
Copy Markdown
Contributor

Thanks @meersuri for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 2, 2022
@meersuri@miss-islington
bpo-46586: Fix more erroneous doc links to builtins (pythonGH-31429)
3445252
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Éric <merwok@netwok.org>
(cherry picked from commit cc6ae4f)
Co-authored-by: Meer Suri <46469858+meersuri@users.noreply.github.com>
@miss-islington

miss-islington commented May 2, 2022

Copy link
Copy Markdown
Contributor

Sorry, @meersuri and @JelleZijlstra, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker cc6ae4f4835f9e76a34f24cd1f666c1cc0fecfa3 3.9

@bedevere-bot

bedevere-bot commented May 2, 2022

Copy link
Copy Markdown

GH-92198 is a backport of this pull request to the 3.10 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.10 only security fixes label May 2, 2022
JelleZijlstra pushed a commit to JelleZijlstra/cpython that referenced this pull request May 2, 2022
@meersuri@JelleZijlstra
[3.9] bpo-46586: Fix more erroneous doc links to builtins (pythonGH-3…
0ccd7f2
…1429)
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Éric <merwok@netwok.org>.
(cherry picked from commit cc6ae4f)
Co-authored-by: Meer Suri <46469858+meersuri@users.noreply.github.com>
@bedevere-bot

bedevere-bot commented May 2, 2022

Copy link
Copy Markdown

GH-92199 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request May 2, 2022
@miss-islington@meersuri
bpo-46586: Fix more erroneous doc links to builtins (GH-31429)
5f40cb8
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Éric <merwok@netwok.org>
(cherry picked from commit cc6ae4f)
Co-authored-by: Meer Suri <46469858+meersuri@users.noreply.github.com>
JelleZijlstra added a commit that referenced this pull request May 3, 2022
@JelleZijlstra@meersuri
[3.9]bpo-46586: Fix more erroneous doc links to builtins (GH-31429) (#…
92d2615
…92199)
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Éric <merwok@netwok.org>.
(cherry picked from commit cc6ae4f)
Co-authored-by: Meer Suri <46469858+meersuri@users.noreply.github.com>
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@JelleZijlstra@meersuri@hello-adam
[3.9] bpo-46586: Fix more erroneous doc links to builtins (pythonGH-3…
a527fa6
…1429) (python#92199)
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Éric <merwok@netwok.org>.
(cherry picked from commit cc6ae4f)
Co-authored-by: Meer Suri <46469858+meersuri@users.noreply.github.com>
@DutchoDutchomannequin mentioned this pull request Apr 10, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@merwokmerwokmerwok left review comments
@JelleZijlstraJelleZijlstraJelleZijlstra approved these changes
@AlexWaygoodAlexWaygoodAlexWaygood left review comments
@ethanfurmanethanfurmanAwaiting requested review from ethanfurman

Assignees

@JelleZijlstraJelleZijlstra

Labels

docsDocumentation in the Doc dirskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@meersuri@AlexWaygood@merwok@JelleZijlstra@miss-islington@bedevere-bot@hugovk@the-knights-who-say-ni