Uh oh!
There was an error while loading. Please reload this page.
bpo-46771: cancel counts - #31434
Merged
Merged
Conversation
Tincheforce-pushed
the
issue-46771-cancel-counts
branch
from
February 20, 2022 23:03
4526894 to
b32bbf9Compareasvetlov
commented
Feb 20, 2022
Contributor
I like it! |
Tinche
commented
Feb 20, 2022
ContributorAuthor
@asvetlov this is a competing proposal to using the |
asvetlov
commented
Feb 20, 2022
Contributor
I understand. |
Tinche
marked this pull request as ready for review
February 20, 2022 23:59
Tinche
commented
Feb 21, 2022
ContributorAuthor
@asvetlov Cool, but you'll need to merge this :) |
bedevere-bot
commented
Feb 21, 2022
@asvetlov: Please replace |
asvetlov
commented
Feb 21, 2022
Contributor
Done. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Task._cancel_requested: boolis nowTask._num_cancels_requested: intTask.cancellingnow returns an intTask.uncancelalso returns an int, the number of remaining cancel requests__exit__, and propagates the CancelError if there are more cancel requestsCancelScope.cancelledis now a propertyI have not updated any of the comments or docs yet.
https://bugs.python.org/issue46771