Skip to content

bpo-46805: Add low level UDP socket functions to asyncio - #31455

Merged
asvetlov merged 14 commits into
python:mainfrom
agronholm:fix-issue-46805
Mar 13, 2022
Merged

bpo-46805: Add low level UDP socket functions to asyncio#31455
asvetlov merged 14 commits into
python:mainfrom
agronholm:fix-issue-46805

Conversation

@agronholm

@agronholmagronholm commented Feb 20, 2022•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor
  • sock_sendto()
  • sock_recvfrom()
  • sock_recvfrom_into()

https://bugs.python.org/issue46805

@agronholm
Added three new raw socket methods to asyncio
5f1cadb
* sock_sendto()
* sock_recvfrom()
* sock_recvfrom_into()
@agronholm
agronholm marked this pull request as ready for review February 27, 2022 23:19
kumaraditya303
kumaraditya303 reviewed Mar 4, 2022
View reviewed changes
Comment threadModules/overlapped.c Outdated
asvetlov
asvetlov reviewed Mar 11, 2022
View reviewed changes
Comment threadLib/asyncio/windows_events.py Outdated
kumaraditya303
kumaraditya303 requested changes Mar 11, 2022
View reviewed changes

@kumaraditya303kumaraditya303 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new methods should be mentioned in 3.11 whatsnew

@agronholm

agronholm commented Mar 11, 2022

Copy link
Copy Markdown
ContributorAuthor

The new methods should be mentioned in 3.11 whatsnew

They're already mentioned in the news blurb in this PR.

@kumaraditya303

kumaraditya303 commented Mar 11, 2022

Copy link
Copy Markdown
Contributor

It should also be mentioned in the Improved Modules section of whatsnew under asyncio.

@agronholm

agronholm commented Mar 11, 2022

Copy link
Copy Markdown
ContributorAuthor

It should also be mentioned in the Improved Modules section of whatsnew under asyncio.

What do I need to do?

@kumaraditya303

kumaraditya303 commented Mar 11, 2022

Copy link
Copy Markdown
Contributor

It should also be mentioned in the Improved Modules section of whatsnew under asyncio.

What do I need to do?

Add new methods here https://github.com/python/cpython/blob/main/Doc/whatsnew/3.11.rst, See https://github.com/python/cpython/blob/main/Doc/whatsnew/3.11.rst#inspect for inspect module as an example.

@agronholm

agronholm commented Mar 11, 2022

Copy link
Copy Markdown
ContributorAuthor

It should also be mentioned in the Improved Modules section of whatsnew under asyncio.

Done.

asvetlov
asvetlov reviewed Mar 11, 2022
View reviewed changes

@asvetlovasvetlov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix minor notes

Comment threadDoc/library/asyncio-eventloop.rst Outdated
Comment threadModules/overlapped.c Outdated
Comment threadModules/overlapped.c Outdated
Comment threadModules/overlapped.c Outdated
asvetlov
asvetlov approved these changes Mar 13, 2022
View reviewed changes

@asvetlovasvetlov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@asvetlov
asvetlov merged commit 9f04ee5 into python:mainMar 13, 2022
@agronholm
agronholm deleted the fix-issue-46805 branch March 13, 2022 16:43
@agronholm

agronholm commented Mar 13, 2022

Copy link
Copy Markdown
ContributorAuthor

Thanks for reviewing!

carljm pushed a commit to carljm/cpython that referenced this pull request Mar 14, 2022
Carl Meyer
Merge branch 'main' into dictwatch
d22463b
* main: (94 commits)
Revert "bpo-46986: Upgrade bundled setuptools to 60.9.3 (pythonGH-31820)" (pythonGH-31879)
bpo-30677: [doc] mention that os.mkdir() can raise FileNotFoundError (pythonGH-31548)
git ignore Lib/site-packages (pythonGH-31862)
bpo-31415: importtime was made by Inada Naoki (pythonGH-31875)
bpo-46920: Remove code that has explainers why it was disabled (pythonGH-31813)
bpo-46920: Remove disabled debug code added decades ago and likely unnecessary (pythonGH-31812)
bpo-46920: Remove code that has no explainer why it was disabled (pythonGH-31814)
bpo-46906: Mention native endian in PyFloat_Pack8() doc (pythonGH-31866)
bpo-40280: select: Use NULL for empty fdset (pythonGH-31865)
CI: Fix patchcheck (pythonGH-31708)
bpo-46987: Remove _PySys_GetObjectId / _PySys_GetObjectId (pythonGH-31835)
bpo-46994: Accept explicit contextvars.Context in asyncio create_task() API (pythonGH-31837)
bpo-39829: Fix `__len__()` is called twice in list() constructor (pythonGH-31816)
bpo-47003: Cleanup _overlapped module (pythonGH-31848)
bpo-47004: Sync with importlib_metadata 4.11.3. (python#31854)
bpo-46986: Upgrade bundled setuptools to 60.9.3 (pythonGH-31820)
bpo-46985: Upgrade bundled pip to 22.0.4 (pythonGH-31819)
bpo-46805: Add low level UDP socket functions to asyncio (pythonGH-31455)
bpo-46995: Deprecate missing asyncio.Task.set_name() for third-party task implementations (pythonGH-31838)
bpo-43215: Document Happy Eyeballs args of asyncio.open_connection (pythonGH-24525)
...
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303kumaraditya303kumaraditya303 requested changes
@asvetlovasvetlovasvetlov approved these changes
@1st11st1Awaiting requested review from 1st11st1 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@agronholm@kumaraditya303@asvetlov@the-knights-who-say-ni@bedevere-bot