Uh oh!
There was an error while loading. Please reload this page.
bpo-46841: Use *inline* caching for BINARY_OP - #31543
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| Use 2 bytes for each instruction. Previously the number of bytes varied | ||
| by instruction. | ||
| .. versionchanged:: 3.11 |
There was a problem hiding this comment.
Maybe don't document this until we are sure it's what we want?
There was a problem hiding this comment.
I'd prefer to keep it, and change it if/when dis changes (which is easy enough). That way we don't forget to document it.
There was a problem hiding this comment.
OK. Once we've started doing this we will need to complete it before the beta release anyway.
markshannon
commented
Feb 24, 2022
Looks good in general. |
bedevere-bot
commented
Feb 24, 2022
🤖 New build scheduled with the buildbot fleet by @brandtbucher for commit 1aa079c 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
markshannon
commented
Feb 25, 2022
👍 |
Here's a sort-of-rough first pass at implementing this idea.
BINARY_OPis easy to start with, since it only uses its cache for the adaptivecountermember. Initial perf testing doesn't show any impact, which I think is good (it means that the basic idea works well, even when the cache isn't being used).Related changes:
disutilities grow ashow_cachesparameter, defaulting toFalse.wordcode_helpers.hhas been moved intocompile.c.https://bugs.python.org/issue46841