Skip to content

bpo-46857: Fix test_embed.test_no_memleak() on Windows - #31589

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:leak_win
Feb 25, 2022
Merged

bpo-46857: Fix test_embed.test_no_memleak() on Windows#31589
vstinner merged 1 commit into
python:mainfrom
vstinner:leak_win

Conversation

@vstinner

@vstinnervstinner commented Feb 25, 2022

Copy link
Copy Markdown
Member

Tolerate a leak of 1 reference and 1 memory block until it's fixed.

https://bugs.python.org/issue46857

Tolerate a leak of 1 reference and 1 memory block until it's fixed.

@kumaraditya303kumaraditya303 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll try to find the leak but till then it is good enough.

@vstinner

Copy link
Copy Markdown
MemberAuthor

LGTM, I'll try to find the leak

Good luck! It can be a bug which exists for many years. See for example my winreg.c fix, it was an old bug.

@vstinner
vstinner merged commit ea9612a into python:mainFeb 25, 2022
@vstinner
vstinner deleted the leak_win branch February 25, 2022 17:24
asvetlov pushed a commit that referenced this pull request Feb 26, 2022
Tolerate a leak of 1 reference and 1 memory block until it's fixed.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@vstinner@kumaraditya303@the-knights-who-say-ni@bedevere-bot