Skip to content

bpo-40280: Block more non-working syscalls in Emscripten (GH-31757) - #31757

Merged
tiran merged 1 commit into
python:mainfrom
tiran:bpo-40280-even-more-syscalls
Mar 8, 2022
Merged

bpo-40280: Block more non-working syscalls in Emscripten (GH-31757)#31757
tiran merged 1 commit into
python:mainfrom
tiran:bpo-40280-even-more-syscalls

Conversation

@tiran

@tirantiran commented Mar 8, 2022

Copy link
Copy Markdown
Member
  • getgroups always fails.
  • geteuid and getegid always return 0 (root), which confuse tarfile and
    tests.
  • hardlinks (link, linkat) always fails.
  • non-encodable file names are not supported by NODERAWFS layer.
  • mark more tests with dependency on subprocess and multiprocessing.
    Mocking does not work if the module fails to import.

Signed-off-by: Christian Heimes christian@python.org

https://bugs.python.org/issue40280

- getgroups always fails.
- geteuid and getegid always return 0 (root), which confuse tarfile and
tests.
- hardlinks (link, linkat) always fails.
- non-encodable file names are not supported by NODERAWFS layer.
- mark more tests with dependency on subprocess and multiprocessing.
Mocking does not work if the module fails to import.
Signed-off-by: Christian Heimes <christian@python.org>
@tirantiran changed the title bpo-40280: Block more non-working syscalls in Emscriptenbpo-40280: Block more non-working syscalls in Emscripten (GH-31757)Mar 8, 2022
@tiran
tiran merged commit 5081e78 into python:mainMar 8, 2022
@tiran
tiran deleted the bpo-40280-even-more-syscalls branch March 8, 2022 11:17
@brettcannon
brettcannon self-requested a review March 8, 2022 20:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@tiran@the-knights-who-say-ni@bedevere-bot