Uh oh!
There was an error while loading. Please reload this page.
bpo-46829: Deprecate passing a message into Future.cancel() and Task.cancel() - #31840
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Please hold off on merging this until we've come to some kind of agreement on whether to deprecate |
gvanrossum
commented
Mar 12, 2022
Also, if we do this we should add deprecation markup to the docs. Search for 'method:: cancel' in asyncio-future.rst and asyncio-task.rst. Also there's a note at the very bottom of asyncio-future.rst about the difference between asyncio.Future.cancel and concurrent.futures.Future.cancel that should be deprecated. |
asvetlov
commented
Mar 12, 2022
Forgot about docs, thanks. |
I've updated the doc. |
gvanrossum
left a comment
There was a problem hiding this comment.
I don't know how long to wait for @cjerdonek to respond or agree.
asvetlov
commented
Mar 19, 2022
@cjerdonek would you comment on this pull request, please? |
gvanrossum
commented
Mar 23, 2022
I'm just going to merge this. @cjerdonek, if you have a convincing argument to keep this, we can always revert this PR. |
gvanrossum
commented
Oct 6, 2022
At the core dev sprint we discussed this and decided to revert this. I'm aiming to get the reversal into 3.11. |
https://bugs.python.org/issue46829